Stream: git-wasmtime

Topic: wasmtime / PR #13517 fix: resolve #13200 — Cranelift: JIT...

Wasmtime GitHub notifications bot (May 31 2026 at 09:42):

chinhkrb113 opened PR #13517 from chinhkrb113:improve/quality/re-export-jitmemorykind-from-the-crate-r to bytecodealliance:main:

Summary

Making JITMemoryKind public in memory.rs is not sufficient if it is not re-exported from the crate root alongside JITMemoryProvider and the other memory-related public items. Downstream users import these symbols from cranelift_jit::..., so the type needs to be reachable through the same path used for JITMemoryProvider

Fixes #13200

Changes

• cranelift/jit/src/lib.rs

Why

cranelift/jit/src/lib.rs: Making JITMemoryKind public in memory.rs is not sufficient if it is not re-exported from the crate root alongside JITMemoryProvider and the other memory-related public items. Downstream users import these symbols from cranelift_jit::..., so the type needs to be reachable through the same path used for JITMemoryProvider.

Wasmtime GitHub notifications bot (May 31 2026 at 09:42):

chinhkrb113 requested wasmtime-compiler-reviewers for a review on PR #13517.

Wasmtime GitHub notifications bot (May 31 2026 at 09:42):

chinhkrb113 requested fitzgen for a review on PR #13517.

Wasmtime GitHub notifications bot (May 31 2026 at 11:17):

github-actions[bot] added the label cranelift on PR #13517.

Wasmtime GitHub notifications bot (Jun 01 2026 at 17:03):

fitzgen commented on PR #13517:

Thanks, but it looks like you didn't run tests because there are compile errors:

https://github.com/bytecodealliance/wasmtime/actions/runs/26709191286/job/78716123018?pr=13517#step:23:322

   Compiling cranelift-jit v0.133.0 (/home/runner/work/wasmtime/wasmtime/cranelift/jit)
error: missing documentation for an enum
  --> cranelift/jit/src/memory/mod.rs:19:1
   |
19 | pub enum JITMemoryKind {
   | ^^^^^^^^^^^^^^^^^^^^^^
   |
note: the lint level is defined here
  --> cranelift/jit/src/lib.rs:6:9
   |
 6 | #![deny(missing_docs, unreachable_pub)]
   |         ^^^^^^^^^^^^

error: could not compile `cranelift-jit` (lib) due to 1 previous error

Wasmtime GitHub notifications bot (Jun 13 2026 at 17:49):

:cross_mark: alexcrichton closed without merge PR #13517.

Wasmtime GitHub notifications bot (Jun 13 2026 at 17:49):

alexcrichton commented on PR #13517:

Landing in https://github.com/bytecodealliance/wasmtime/pull/13632

Last updated: Jul 29 2026 at 05:03 UTC