Stream: git-wasmtime

Topic: wasmtime / PR #13515 fix: reclaim host stream/future tran...

Wasmtime GitHub notifications bot (May 31 2026 at 23:31):

gfx edited PR #13515.

Wasmtime GitHub notifications bot (Jun 01 2026 at 14:39):

alexcrichton unassigned dicej from PR #13515 fix: reclaim host stream/future transmits when the guest drops its end.

Wasmtime GitHub notifications bot (Jun 01 2026 at 14:39):

alexcrichton requested alexcrichton for a review on PR #13515.

Wasmtime GitHub notifications bot (Jun 01 2026 at 15:35):

:memo: alexcrichton submitted PR review:

Thanks! I've got a question about the conditional drop, but otherwise this all looks reasonable to me

Wasmtime GitHub notifications bot (Jun 01 2026 at 15:35):

:speech_balloon: alexcrichton created PR review comment:

I'm not sure I fully understand why this is conditional, can you explain this a bit more? For example if the write state is not dropped, meaning that this isn't executed, then I believe it's only possible to get here by flowing through the WriteState::HostReady, but that means that the host actually owns the writer. This function is only called when the guest drops the writer, so I'm not sure how that's possible.

Are there tests for this conditional branch? Or if this branch goes away and the delete_transmit unconditionally happens, what bad would happen? (e.g. could a test be written to exercise that?)

Wasmtime GitHub notifications bot (Jun 01 2026 at 17:55):

pchickey commented on PR #13515:

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gfx The BA asks that all AI agent interactions by our contributors are mediated by the contributor, not sent to the BA repos directly https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.md#details - in the future please do not request the copilot agent to leave reviews on PRs, if you want to use copilot to review your work you can do that prior to submission.

Wasmtime GitHub notifications bot (Jun 08 2026 at 00:23):

gfx commented on PR #13515:

Thank you for review. Will handle the review later, but I'm marking this PR as draft for now.

Wasmtime GitHub notifications bot (Jun 08 2026 at 00:23):

gfx converted PR #13515 fix: reclaim host stream/future transmits when the guest drops its end to a draft.

Wasmtime GitHub notifications bot (Jun 16 2026 at 00:15):

:cross_mark: alexcrichton closed without merge PR #13515.

Last updated: Jul 29 2026 at 05:03 UTC