Wasmtime GitHub notifications bot (May 29 2026 at 19:05): Wasmtime GitHub notifications bot (May 29 2026 at 19:05):fitzgen opened PR #13509 from fitzgen:issue-13365-branch-optimizations-bug-take-2 to bytecodealliance:main:
The DFS could visit reachable blocks before their predecessors marked them as reachable, which meant that other reachable blocks that they dominated wouldn't get marked reachable. This commit removes the complication of trying to compute the set of reachable blocks incrementally inside
remove_pure_and_optimize, and simply rebuilds the CFG and finds the reachable blocks in batch afterwards.Fixes https://github.com/bytecodealliance/wasmtime/issues/13365
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 29 2026 at 19:05):fitzgen requested cfallin for a review on PR #13509.
Wasmtime GitHub notifications bot (May 29 2026 at 19:05):fitzgen requested wasmtime-compiler-reviewers for a review on PR #13509.
Wasmtime GitHub notifications bot (May 29 2026 at 19:38)::thumbs_up: cfallin submitted PR review.
Wasmtime GitHub notifications bot (May 29 2026 at 19:39):cfallin added PR #13509 Compute reachable blocks in batch during egraph pass to the merge queue.
Wasmtime GitHub notifications bot (May 29 2026 at 20:02)::check: cfallin merged PR #13509.
Wasmtime GitHub notifications bot (May 29 2026 at 20:02):cfallin removed PR #13509 Compute reachable blocks in batch during egraph pass from the merge queue.
Last updated: Jun 01 2026 at 09:49 UTC