Stream: git-wasmtime

Topic: wasmtime / PR #13500 wasmtime: generalize InstanceExportL...

Wasmtime GitHub notifications bot (May 27 2026 at 23:28):

pchickey requested alexcrichton for a review on PR #13500.

Wasmtime GitHub notifications bot (May 27 2026 at 23:28):

pchickey requested wasmtime-core-reviewers for a review on PR #13500.

Wasmtime GitHub notifications bot (May 27 2026 at 23:28):

pchickey opened PR #13500 from pchickey:pch/export_lookup to bytecodealliance:main:

The wasmtime::component::Instance struct had getter methods that accepted impl InstanceExportLookup, a pseudo-sealed trait (via #[doc(hidden)]) with impls for &str, String, or ComponentExportIndex.

Conversely, the wasmtime::component::Component struct had get_export and get_export_index methods which took arguments instance: Option<&ComponentExportIndex> and name: &str.

This PR renames the trait to ExportLookup, with the exact same impls, and modifies the Component::get_export[_index] methods to take impl ExportLookup instead of &str arguments.

This is motivated by a follow-up PR that will add wit_parser::ItemName as another type that impls ExportIndex.

Wasmtime GitHub notifications bot (May 27 2026 at 23:41):

pchickey updated PR #13500.

Wasmtime GitHub notifications bot (May 28 2026 at 00:00):

pchickey updated PR #13500.

Wasmtime GitHub notifications bot (May 28 2026 at 01:05):

:thumbs_up: alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (May 28 2026 at 01:05):

alexcrichton added PR #13500 wasmtime: generalize InstanceExportLookup into ExportLookup to the merge queue.

Wasmtime GitHub notifications bot (May 28 2026 at 01:29):

github-merge-queue[bot] removed PR #13500 wasmtime: generalize InstanceExportLookup into ExportLookup from the merge queue.

Wasmtime GitHub notifications bot (May 28 2026 at 20:09):

pchickey updated PR #13500.

Wasmtime GitHub notifications bot (May 28 2026 at 20:10):

pchickey has enabled auto merge for PR #13500.

Wasmtime GitHub notifications bot (May 28 2026 at 20:19):

pchickey added PR #13500 wasmtime: generalize InstanceExportLookup into ExportLookup to the merge queue.

Wasmtime GitHub notifications bot (May 28 2026 at 21:05):

github-merge-queue[bot] removed PR #13500 wasmtime: generalize InstanceExportLookup into ExportLookup from the merge queue.

Wasmtime GitHub notifications bot (May 28 2026 at 21:21):

pchickey added PR #13500 wasmtime: generalize InstanceExportLookup into ExportLookup to the merge queue.

Wasmtime GitHub notifications bot (May 28 2026 at 21:21):

pchickey commented on PR #13500:

Last merge queue failure was because a mac ci runner hung

Wasmtime GitHub notifications bot (May 28 2026 at 21:45):

:check: pchickey merged PR #13500.

Wasmtime GitHub notifications bot (May 28 2026 at 21:45):

pchickey removed PR #13500 wasmtime: generalize InstanceExportLookup into ExportLookup from the merge queue.

Last updated: Jun 01 2026 at 09:49 UTC