Stream: git-wasmtime

Topic: wasmtime / PR #1347 Handle select relocations while gener...

Wasmtime GitHub notifications bot (Mar 17 2020 at 19:55):

alexcrichton opened PR #1347 from fix-trampoline-relocations to master:

Trampoline generation for all function signatures exposed a preexisting
bug in wasmtime where trampoline generation occasionally does have
relocations, but it's asserted that trampolines don't generate
relocations, causing a panic. The relocation is currently primarily the
probestack function which happens when functions might have a huge
number of parameters, but not so huge as to blow the wasmparser limit of
how many parameters are allowed.

This commit fixes the issue by handling relocations for trampolines in
the same manner as the rest of the code. Note that dynamically-generated
trampolines via the Func API still panic if they have too many
arguments and generate a relocation, but it seems like we can try to fix
that later if the need truly arises.

Closes #1322

Wasmtime GitHub notifications bot (Mar 17 2020 at 20:51):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 17 2020 at 21:01):

alexcrichton updated PR #1347 from fix-trampoline-relocations to master:

Trampoline generation for all function signatures exposed a preexisting
bug in wasmtime where trampoline generation occasionally does have
relocations, but it's asserted that trampolines don't generate
relocations, causing a panic. The relocation is currently primarily the
probestack function which happens when functions might have a huge
number of parameters, but not so huge as to blow the wasmparser limit of
how many parameters are allowed.

This commit fixes the issue by handling relocations for trampolines in
the same manner as the rest of the code. Note that dynamically-generated
trampolines via the Func API still panic if they have too many
arguments and generate a relocation, but it seems like we can try to fix
that later if the need truly arises.

Closes #1322

Wasmtime GitHub notifications bot (Mar 17 2020 at 21:30):

alexcrichton merged PR #1347.

Last updated: Dec 23 2024 at 12:05 UTC