Stream: git-wasmtime

Topic: wasmtime / PR #1344 Re-add Cranelift publish script

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 17:12):

fitzgen opened PR #1344 from cranelift-publish-script to master.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 17:12):

fitzgen requested bnjbvr for a review on PR #1344.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 17:13):

fitzgen updated PR #1344 from cranelift-publish-script to master.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 17:55):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 17:55):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 17:55):

bnjbvr created PR Review Comment:

nit: Cranelift

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 17:55):

bnjbvr created PR Review Comment:

May I suggest to actually print this message? It's likely users of this script won't look at its source when using it.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 17:55):

bnjbvr created PR Review Comment:

The previous script did print on the terminal the instructions to run for the git tag et al., is this something we'd like to keep on doing here?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 17:55):

bnjbvr created PR Review Comment:

nit: Wasmtime

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 19:57):

fitzgen updated PR #1344 from cranelift-publish-script to master.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 19:59):

fitzgen merged PR #1344.

Last updated: Oct 23 2024 at 20:03 UTC