Wasmtime GitHub notifications bot (May 21 2026 at 19:34): Wasmtime GitHub notifications bot (May 21 2026 at 19:34):alexcrichton opened PR #13438 from alexcrichton:gc-arrays-are-entities to bytecodealliance:main:
This commit updates as necessary to route GC array copies/fills/etc through the
translate_entity_*infrastructure. This helps ensure that everything stays in the same funnel to get fuel checks, bounds checks, epoch checks, etc. The primary purpose of this commit is refactoring and code deduplication.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 21 2026 at 19:34):alexcrichton requested cfallin for a review on PR #13438.
Wasmtime GitHub notifications bot (May 21 2026 at 19:34):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #13438.
Wasmtime GitHub notifications bot (May 21 2026 at 19:34):alexcrichton requested wasmtime-core-reviewers for a review on PR #13438.
Wasmtime GitHub notifications bot (May 21 2026 at 19:42)::memo: fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 21 2026 at 19:42)::speech_balloon: fitzgen created PR review comment:
Why did this signature become fallible even though the function itself isn't fallible? This (along with the similar change to
get_gc_heap_bound) seems to have added a whole bunch of noise to the diff.
Wasmtime GitHub notifications bot (May 21 2026 at 20:05)::memo: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 21 2026 at 20:05)::speech_balloon: alexcrichton created PR review comment:
This was needed because the
func_environ.rsfile started calling this function, but it's only conditionally defined depending on thegcfeature.Personally I'd like to actually remove the crate features of the
wasmtime-internal-craneliftcrate entirely since I don't think we benefit much from conditionally-compiled compiler code and it'd clean up the internals quite a bit (and be easier to mantain). I figured I'd defer that to a future PR though.
Wasmtime GitHub notifications bot (May 21 2026 at 20:06)::memo: fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 21 2026 at 20:06)::speech_balloon: fitzgen created PR review comment:
Ah okay, that makes sense. Will take a look at this PR in a minute.
Wasmtime GitHub notifications bot (May 21 2026 at 20:18):alexcrichton updated PR #13438.
Wasmtime GitHub notifications bot (May 21 2026 at 21:08)::thumbs_up: fitzgen submitted PR review:
LGTM!
Wasmtime GitHub notifications bot (May 21 2026 at 21:08):fitzgen added PR #13438 Route GC arrays through translate_entity_* to the merge queue
Wasmtime GitHub notifications bot (May 21 2026 at 21:45)::check: fitzgen merged PR #13438.
Wasmtime GitHub notifications bot (May 21 2026 at 21:45):fitzgen removed PR #13438 Route GC arrays through translate_entity_* from the merge queue
Last updated: Jun 01 2026 at 09:49 UTC