Wasmtime GitHub notifications bot (May 19 2026 at 22:36): Wasmtime GitHub notifications bot (May 19 2026 at 22:36):dicej requested alexcrichton for a review on PR #13415.
Wasmtime GitHub notifications bot (May 19 2026 at 22:36):dicej requested wasmtime-core-reviewers for a review on PR #13415.
Wasmtime GitHub notifications bot (May 19 2026 at 22:36):dicej opened PR #13415 from dicej:waitable-sync-async-trap to bytecodealliance:main:
...and vice-versa.
Per https://github.com/WebAssembly/component-model/pull/647, a waitable may not be added to a waitable-set while it's being used in a synchronous operation, nor may a waitable that's already added to a waitable-set be used in a synchronous operation.
Test case courtesy of Alex via #13212.
Fixes #13212
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 20 2026 at 00:04):github-actions[bot] added the label wasmtime:api on PR #13415.
Wasmtime GitHub notifications bot (May 20 2026 at 00:04):github-actions[bot] added the label wasmtime:c-api on PR #13415.
Wasmtime GitHub notifications bot (May 20 2026 at 15:41):dicej updated PR #13415.
Wasmtime GitHub notifications bot (May 20 2026 at 15:48):I realized we don't have a test yet for adding a waitable to a set while it's involved in a sync operation; will add one.
Wasmtime GitHub notifications bot (May 20 2026 at 18:08):dicej updated PR #13415.
Wasmtime GitHub notifications bot (May 23 2026 at 11:37)::thumbs_up: alexcrichton submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (May 23 2026 at 11:37):alexcrichton added PR #13415 trap if waitable added to waitable-set while used synchronously to the merge queue.
Wasmtime GitHub notifications bot (May 23 2026 at 11:56):github-merge-queue[bot] removed PR #13415 trap if waitable added to waitable-set while used synchronously from the merge queue.
Wasmtime GitHub notifications bot (May 23 2026 at 13:52):alexcrichton added PR #13415 trap if waitable added to waitable-set while used synchronously to the merge queue.
Wasmtime GitHub notifications bot (May 23 2026 at 14:33):github-merge-queue[bot] removed PR #13415 trap if waitable added to waitable-set while used synchronously from the merge queue.
Wasmtime GitHub notifications bot (May 23 2026 at 22:49):alexcrichton added PR #13415 trap if waitable added to waitable-set while used synchronously to the merge queue.
Wasmtime GitHub notifications bot (May 23 2026 at 23:12)::check: alexcrichton merged PR #13415.
Wasmtime GitHub notifications bot (May 23 2026 at 23:12):alexcrichton removed PR #13415 trap if waitable added to waitable-set while used synchronously from the merge queue.
Last updated: Jun 01 2026 at 09:49 UTC