Stream: git-wasmtime

Topic: wasmtime / PR #1340 Simplify ssa builder

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:55):

Y-Nak opened PR #1340 from simplify-ssa-builder to master:

• [x] This has been discussed in issue #1259
• [x] A short description of what this does, why it is needed;
  Current implementation of SSABuilder has redundant fields and depends on redundant function/struct in order to work with EBB.

Update info

• Remove redundant struct/fields/method/function
• Update docs

• Update tests

• [x] This PR contains test cases, if meaningful.

• [x] A reviewer from the core maintainer team has been assigned for this PR.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:56):

Y-Nak edited PR #1340 from simplify-ssa-builder to master:

• [x] This has been discussed in issue #1259
• [x] A short description of what this does, why it is needed;
  Current implementation of SSABuilder has redundant fields and depends on redundant function/struct in order to work with EBB.

Update info

• Remove redundant struct/fields/method/function
• Update docs

• Update tests

• [x] This PR contains test cases, if meaningful.

• [x] A reviewer from the core maintainer team has been assigned for this PR.
  r? @bnjbvr @eqrion

Wasmtime GitHub notifications bot (Mar 17 2020 at 16:00):

Y-Nak edited PR #1340 from simplify-ssa-builder to master:

• [x] This has been discussed in issue #1259
• [x] A short description of what this does, why it is needed;
  Current implementation of SSABuilder has redundant fields and depends on redundant function/struct in order to work with EBB.

Update info

• Remove redundant structs/fields/methods/functions
• Update docs

• Update tests

• [x] This PR contains test cases, if meaningful.

• [x] A reviewer from the core maintainer team has been assigned for this PR.
  r? @bnjbvr @eqrion

Wasmtime GitHub notifications bot (Mar 17 2020 at 16:03):

Y-Nak edited PR #1340 from simplify-ssa-builder to master:

• [x] This has been discussed in issue #1259
• [x] A short description of what this does, why it is needed;
  Current implementation of SSABuilder has redundant fields and depends on redundant function/struct in order to work with EBB.

Update info

• Remove redundant structs/fields/methods/functions in cranelift/frontend/src/ssa.rs
• Adapt to updated SSABuilder in FunctionBuilder
• Update docs

• Update tests

• [x] This PR contains test cases, if meaningful.

• [x] A reviewer from the core maintainer team has been assigned for this PR.
  r? @bnjbvr @eqrion

Wasmtime GitHub notifications bot (Mar 17 2020 at 16:09):

Y-Nak edited PR #1340 from simplify-ssa-builder to master:

• [x] This has been discussed in issue #1259
• [x] A short description of what this does, why it is needed;
  Fixes #1259

Update info

• Remove redundant struct/fields/method/function
• Update docs

• Update tests

• [x] This PR contains test cases, if meaningful.

• [x] A reviewer from the core maintainer team has been assigned for this PR.
  r? @bnjbvr @eqrion

Wasmtime GitHub notifications bot (Mar 17 2020 at 16:17):

Y-Nak edited PR #1340 from simplify-ssa-builder to master:

• [x] This has been discussed in issue #1259
• [x] A short description of what this does, why it is needed;
  Fixes #1259

Update info

• Remove redundant structs/fields/methods/functions from cranelift/frontend/src/ssa.rs
• Adapt FunctionBuilder to updated SSABuilder
• Update docs

• Update tests

• [x] This PR contains test cases, if meaningful.

• [x] A reviewer from the core maintainer team has been assigned for this PR.
  r? @bnjbvr @eqrion

Wasmtime GitHub notifications bot (Mar 17 2020 at 16:25):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 19 2020 at 01:30):

Y-Nak updated PR #1340 from simplify-ssa-builder to master:

• [x] This has been discussed in issue #1259
• [x] A short description of what this does, why it is needed;
  Fixes #1259

Update info

• Remove redundant structs/fields/methods/functions from cranelift/frontend/src/ssa.rs
• Adapt FunctionBuilder to updated SSABuilder
• Update docs

• Update tests

• [x] This PR contains test cases, if meaningful.

• [x] A reviewer from the core maintainer team has been assigned for this PR.
  r? @bnjbvr @eqrion

Wasmtime GitHub notifications bot (Mar 20 2020 at 18:54):

sunfishcode merged PR #1340.

Last updated: Dec 06 2025 at 06:05 UTC