Wasmtime GitHub notifications bot (May 15 2026 at 22:34): Wasmtime GitHub notifications bot (May 15 2026 at 22:34):cfallin requested wasmtime-compiler-s390x-reviewers for a review on PR #13392.
Wasmtime GitHub notifications bot (May 15 2026 at 22:34):cfallin opened PR #13392 from cfallin:machbuffer-refactor to bytecodealliance:main:
Fixes #12968.
It turns out that the actual fix is pretty simple if we permit islands to occur in the middle of basic blocks, which is I think also actually necessary in some corner cases: making that check, and reasoning about the maximal new contribution of island size from each instruction, lets us avoid having to cleverly sort island contents and dispense with deadlines in a just-in-time order. I am happy that this is both simpler to reason about and verify at a glance, and also more robust.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 15 2026 at 22:34):cfallin requested alexcrichton for a review on PR #13392.
Wasmtime GitHub notifications bot (May 15 2026 at 22:34):cfallin requested wasmtime-compiler-reviewers for a review on PR #13392.
Wasmtime GitHub notifications bot (May 15 2026 at 23:44)::thumbs_up: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 16 2026 at 03:57):github-actions[bot] added the label cranelift:area:x64 on PR #13392.
Wasmtime GitHub notifications bot (May 16 2026 at 03:57):github-actions[bot] added the label cranelift:area:aarch64 on PR #13392.
Wasmtime GitHub notifications bot (May 16 2026 at 03:57):github-actions[bot] added the label cranelift on PR #13392.
Wasmtime GitHub notifications bot (May 16 2026 at 03:57):github-actions[bot] added the label cranelift:area:machinst on PR #13392.
Wasmtime GitHub notifications bot (May 16 2026 at 21:55):cfallin updated PR #13392.
Wasmtime GitHub notifications bot (May 16 2026 at 21:55):cfallin has enabled auto merge for PR #13392.
Wasmtime GitHub notifications bot (May 16 2026 at 22:10):cfallin added PR #13392 Cranelift: MachBuffer: resolve deadline issues with very large islands. to the merge queue
Wasmtime GitHub notifications bot (May 16 2026 at 22:34)::check: cfallin merged PR #13392.
Wasmtime GitHub notifications bot (May 16 2026 at 22:34):cfallin removed PR #13392 Cranelift: MachBuffer: resolve deadline issues with very large islands. from the merge queue
Last updated: Jun 01 2026 at 09:49 UTC