Stream: git-wasmtime

Topic: wasmtime / PR #1339 [cranelift docs] Fix grammar code blo...

Wasmtime GitHub notifications bot (Mar 17 2020 at 14:31):

samrat opened PR #1339 from cranelift-ir-doc-formatting to master:

• Move grammar segments in IR docs to code blocks
• Replace dot code in IR docs with generated image.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:13):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:13):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:13):

bjorn3 created PR Review Comment:

That was a rst annotation for the code block language, just like

```productionlist

for markdown.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:13):

bjorn3 created PR Review Comment:

Maybe keep the original .dot file somewhere?

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:13):

bjorn3 created PR Review Comment:

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:14):

bjorn3 edited PR Review Comment.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:20):

samrat updated PR #1339 from cranelift-ir-doc-formatting to master:

• Move grammar segments in IR docs to code blocks
• Replace dot code in IR docs with generated image.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:26):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:26):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:26):

bjorn3 created PR Review Comment:

function_list : { function }
function      : "function" function_name signature "{" preamble function_body "}"
preamble      : { preamble_decl }
function_body : { extended_basic_block }

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:26):

bjorn3 created PR Review Comment:

signature    : "(" [paramlist] ")" ["->" retlist] [call_conv]
paramlist    : param { "," param }
retlist      : paramlist
param        : type [paramext] [paramspecial]
paramext     : "uext" | "sext"
paramspecial : "sret" | "link" | "fp" | "csr" | "vmctx" | "sigid" | "stack_limit"
callconv     : "fast" | "cold" | "system_v" | "fastcall" | "baldrdash_system_v" | "baldrdash_windows"

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:33):

samrat updated PR #1339 from cranelift-ir-doc-formatting to master:

• Move grammar segments in IR docs to code blocks
• Replace dot code in IR docs with generated image.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:38):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:38):

sunfishcode created PR Review Comment:

As a super minor nit: this ] should be indented at the level of the node [, for consistency with how bracketed constructs are typically formatted in Rust.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:38):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 17 2020 at 17:49):

samrat updated PR #1339 from cranelift-ir-doc-formatting to master:

• Move grammar segments in IR docs to code blocks
• Replace dot code in IR docs with generated image.

Wasmtime GitHub notifications bot (Mar 18 2020 at 21:51):

sunfishcode merged PR #1339.

Last updated: Dec 23 2024 at 12:05 UTC