Stream: git-wasmtime

Topic: wasmtime / PR #13381 Fix the copying collector bug(s) tri...


view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 01:28):

fitzgen opened PR #13381 from fitzgen:kotlin-benchmark-bug to bytecodealliance:main:

See each commit for details.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 01:28):

fitzgen requested cfallin for a review on PR #13381.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 01:28):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #13381.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 01:28):

fitzgen requested wasmtime-core-reviewers for a review on PR #13381.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 01:37):

fitzgen updated PR #13381.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 01:58):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 01:58):

:speech_balloon: alexcrichton created PR review comment:

This local is never set in this test? (the branching condition is a bit confusing to me, not sure what the intention was )

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 01:58):

:speech_balloon: alexcrichton created PR review comment:

ditto with lack of set

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 01:58):

:speech_balloon: alexcrichton created PR review comment:

Similar to above, this local is never set?

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 15:08):

:memo: fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 15:08):

:speech_balloon: fitzgen created PR review comment:

It is there to make sure that the loop is an actual loop, but that the second use+assert is not on the back edge, which was required to trigger this bug. I'll tweak things to make that more clear, and we don't need a local that is implicitly zero to do that.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 15:13):

fitzgen updated PR #13381.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 15:13):

fitzgen has enabled auto merge for PR #13381.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 15:23):

fitzgen added PR #13381 Fix the copying collector bug(s) triggered by the Kotlin benchmarks to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 15:48):

:check: fitzgen merged PR #13381.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2026 at 15:48):

fitzgen removed PR #13381 Fix the copying collector bug(s) triggered by the Kotlin benchmarks from the merge queue.


Last updated: Jun 01 2026 at 09:49 UTC