pchickey opened PR #1336 from pch/wiggle_tweaks_for_lucet
to master
:
- wiggle-generate: fix bug where it would panic on an anonymous array type
- a witx
usize
is a rustu32
, not a rustusize
. Rustisize
andusize
are notGuestType
s, because they have a different representation depending on the Rust host.- always pass
GuestPtr
to the module trait methods by reference. This was inconsistent - would be reference for arrays and strings, but not for regular@witx pointer
types.
pchickey requested kubkon for a review on PR #1336.
pchickey edited PR #1336 from pch/wiggle_tweaks_for_lucet
to master
:
based on top of #1311
- wiggle-generate: fix bug where it would panic on an anonymous array type
- a witx
usize
is a rustu32
, not a rustusize
. Rustisize
andusize
are notGuestType
s, because they have a different representation depending on the Rust host.- always pass
GuestPtr
to the module trait methods by reference. This was inconsistent - would be reference for arrays and strings, but not for regular@witx pointer
types.
pchickey updated PR #1336 from pch/wiggle_tweaks_for_lucet
to master
:
based on top of #1311
- wiggle-generate: fix bug where it would panic on an anonymous array type
- a witx
usize
is a rustu32
, not a rustusize
. Rustisize
andusize
are notGuestType
s, because they have a different representation depending on the Rust host.- always pass
GuestPtr
to the module trait methods by reference. This was inconsistent - would be reference for arrays and strings, but not for regular@witx pointer
types.
pchickey edited PR #1336 from pch/wiggle_tweaks_for_lucet
to master
:
- wiggle-generate: fix bug where it would panic on an anonymous array type
- a witx
usize
is a rustu32
, not a rustusize
. Rustisize
andusize
are notGuestType
s, because they have a different representation depending on the Rust host.- always pass
GuestPtr
to the module trait methods by reference. This was inconsistent - would be reference for arrays and strings, but not for regular@witx pointer
types.
pchickey updated PR #1336 from pch/wiggle_tweaks_for_lucet
to master
:
- wiggle-generate: fix bug where it would panic on an anonymous array type
- a witx
usize
is a rustu32
, not a rustusize
. Rustisize
andusize
are notGuestType
s, because they have a different representation depending on the Rust host.- always pass
GuestPtr
to the module trait methods by reference. This was inconsistent - would be reference for arrays and strings, but not for regular@witx pointer
types.
pchickey requested alexcrichton, and kubkon for a review on PR #1336.
alexcrichton submitted PR Review.
pchickey merged PR #1336.
Last updated: Dec 23 2024 at 12:05 UTC