Stream: git-wasmtime

Topic: wasmtime / PR #1336 [wiggle] Tweaks from lucet integration

Wasmtime GitHub notifications bot (Mar 17 2020 at 01:33):

pchickey opened PR #1336 from pch/wiggle_tweaks_for_lucet to master:

• wiggle-generate: fix bug where it would panic on an anonymous array type
• a witx usize is a rust u32, not a rust usize. Rust isize and usize are not GuestTypes, because they have a different representation depending on the Rust host.
• always pass GuestPtr to the module trait methods by reference. This was inconsistent - would be reference for arrays and strings, but not for regular @witx pointer types.

Wasmtime GitHub notifications bot (Mar 17 2020 at 01:33):

pchickey requested kubkon for a review on PR #1336.

Wasmtime GitHub notifications bot (Mar 17 2020 at 01:35):

pchickey edited PR #1336 from pch/wiggle_tweaks_for_lucet to master:

based on top of #1311

• wiggle-generate: fix bug where it would panic on an anonymous array type
• a witx usize is a rust u32, not a rust usize. Rust isize and usize are not GuestTypes, because they have a different representation depending on the Rust host.
• always pass GuestPtr to the module trait methods by reference. This was inconsistent - would be reference for arrays and strings, but not for regular @witx pointer types.

Wasmtime GitHub notifications bot (Mar 17 2020 at 18:43):

pchickey updated PR #1336 from pch/wiggle_tweaks_for_lucet to master:

based on top of #1311

• wiggle-generate: fix bug where it would panic on an anonymous array type
• a witx usize is a rust u32, not a rust usize. Rust isize and usize are not GuestTypes, because they have a different representation depending on the Rust host.
• always pass GuestPtr to the module trait methods by reference. This was inconsistent - would be reference for arrays and strings, but not for regular @witx pointer types.

Wasmtime GitHub notifications bot (Mar 17 2020 at 23:01):

pchickey edited PR #1336 from pch/wiggle_tweaks_for_lucet to master:

• wiggle-generate: fix bug where it would panic on an anonymous array type
• a witx usize is a rust u32, not a rust usize. Rust isize and usize are not GuestTypes, because they have a different representation depending on the Rust host.
• always pass GuestPtr to the module trait methods by reference. This was inconsistent - would be reference for arrays and strings, but not for regular @witx pointer types.

Wasmtime GitHub notifications bot (Mar 20 2020 at 21:19):

pchickey updated PR #1336 from pch/wiggle_tweaks_for_lucet to master:

• wiggle-generate: fix bug where it would panic on an anonymous array type
• a witx usize is a rust u32, not a rust usize. Rust isize and usize are not GuestTypes, because they have a different representation depending on the Rust host.
• always pass GuestPtr to the module trait methods by reference. This was inconsistent - would be reference for arrays and strings, but not for regular @witx pointer types.

Wasmtime GitHub notifications bot (Mar 20 2020 at 21:21):

pchickey requested alexcrichton, and kubkon for a review on PR #1336.

Wasmtime GitHub notifications bot (Mar 20 2020 at 21:24):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Mar 20 2020 at 21:48):

pchickey merged PR #1336.

Last updated: Oct 23 2024 at 20:03 UTC