Stream: git-wasmtime

Topic: wasmtime / PR #1335 Infer REX prefix for SIMD operations;...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 01:28):

abrown opened PR #1335 from infer-rex to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 01:28):

abrown requested bnjbvr for a review on PR #1335.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 01:28):

abrown requested bnjbvr, and iximeow for a review on PR #1335.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 16:26):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 16:26):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 16:26):

bnjbvr created PR Review Comment:

As discussed, whenever we need the REX.W bit to be set, we can just use rex() instead of infer_rex(), so it avoids the runtime decision.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 16:26):

bnjbvr created PR Review Comment:

ditto here

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 16:26):

bnjbvr created PR Review Comment:

Do we need the clone on template.clone()? infer_rex takes &self and returns a copy, if I'm not mistaken.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 16:26):

bnjbvr created PR Review Comment:

ditto here

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 16:26):

bnjbvr created PR Review Comment:

nit: ditto here

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 16:26):

bnjbvr created PR Review Comment:

Ditto here.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 16:26):

bnjbvr created PR Review Comment:

If that's not too much hassle, can you, for each different recipe involved, duplicate the test with a register that would require a REX prefix, please?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 16:30):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 16:30):

abrown created PR Review Comment:

I will change this and I opened #1342 to avoid this type of thing altogether.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2020 at 16:35):

abrown updated PR #1335 from infer-rex to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2020 at 16:40):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2020 at 16:40):

abrown created PR Review Comment:

Ok, I added some REX-inducing tests; it's not 100% coverage but that is a rather high bar with all of the variations of these instructions.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2020 at 17:12):

abrown merged PR #1335.


Last updated: Dec 23 2024 at 13:07 UTC