Wasmtime GitHub notifications bot (May 13 2026 at 23:09): Wasmtime GitHub notifications bot (May 13 2026 at 23:09):posborne edited PR #13345.
Wasmtime GitHub notifications bot (May 13 2026 at 23:15):alexcrichton requested alexcrichton for a review on PR #13345.
Wasmtime GitHub notifications bot (May 13 2026 at 23:15):alexcrichton unassigned pchickey from PR #13345 wasi-http: p3 single-instance-per-request coverage and fixes.
Wasmtime GitHub notifications bot (May 14 2026 at 18:55)::thumbs_up: alexcrichton submitted PR review:
Everything here looks reasonable to me, but I also get tangled up in the futures here. CI looks like it's failing also on a channel/future-related thing which seems like it might be either a preexisting race or one accidentally introduced here?
Wasmtime GitHub notifications bot (May 14 2026 at 18:55)::speech_balloon: alexcrichton created PR review comment:
It's ok to drop the mention of the old code here, no need to document what-once-was and I think the first part of these docs stand well on their own
Wasmtime GitHub notifications bot (May 14 2026 at 19:01):posborne commented on PR #13345:
CI looks like it's failing also on a channel/future-related thing which seems like it might be either a preexisting race or one accidentally introduced here?
I'm working on reproducing this; it's similar to some of the kind of races I saw in the existing code which I had hoped had been addressed but some more digging is clearly warranted.
Wasmtime GitHub notifications bot (May 26 2026 at 21:48):posborne updated PR #13345.
Wasmtime GitHub notifications bot (May 27 2026 at 17:57):alexcrichton commented on PR #13345:
@posborne the most recent commit looks reasonable to me, but did you want to test/adjust more other than that? If not this'll need a rebase after https://github.com/bytecodealliance/wasmtime/pull/13404, and if so just lemme know when you feel this is ready
Wasmtime GitHub notifications bot (May 27 2026 at 18:18):posborne commented on PR #13345:
@alexcrichton I think it's ready to go, was just waiting on CI yesterday -- I did get a local repro so was fairly confident in the patch.
I can do the rebase and put it into the merge queue when ready.
Wasmtime GitHub notifications bot (May 27 2026 at 20:36):posborne updated PR #13345.
Wasmtime GitHub notifications bot (May 28 2026 at 19:34):posborne updated PR #13345.
Last updated: Jun 01 2026 at 09:49 UTC