Wasmtime GitHub notifications bot (May 08 2026 at 03:53): Wasmtime GitHub notifications bot (May 08 2026 at 03:53):alexcrichton opened PR #13324 from alexcrichton:aarch64-one-ueq to bytecodealliance:main:
This fills out an
unimplemented!()block in the aarch64 backed for theUnorderedOrEqualandOrderedNotEqualfloat comparisons. These aren't reachable from WebAssembly and are not as trivial as other orderings to implement, but with the refactoring in #13315 the implementation isn't too hairy. The lowerings are sub-optimal forbrif,trapnz*andselectbut they should at least work now. Notes are left for where the lowerings can be improved, and disassembly/runtests were added for many pieces here.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 08 2026 at 03:53):alexcrichton requested fitzgen for a review on PR #13324.
Wasmtime GitHub notifications bot (May 08 2026 at 03:53):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #13324.
Wasmtime GitHub notifications bot (May 08 2026 at 07:08):github-actions[bot] added the label cranelift on PR #13324.
Wasmtime GitHub notifications bot (May 08 2026 at 07:08):github-actions[bot] added the label cranelift:area:aarch64 on PR #13324.
Wasmtime GitHub notifications bot (May 08 2026 at 07:08):github-actions[bot] added the label isle on PR #13324.
Wasmtime GitHub notifications bot (May 08 2026 at 07:09):github-actions[bot] commented on PR #13324:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (May 12 2026 at 18:16)::thumbs_up: fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 12 2026 at 18:16)::speech_balloon: fitzgen created PR review comment:
Not necessary anymore?
Wasmtime GitHub notifications bot (May 12 2026 at 20:00):alexcrichton updated PR #13324.
Wasmtime GitHub notifications bot (May 12 2026 at 20:00):alexcrichton has enabled auto merge for PR #13324.
Wasmtime GitHub notifications bot (May 12 2026 at 20:26):alexcrichton added PR #13324 aarch64: Implement scalar ueq and one comparisons to the merge queue.
Wasmtime GitHub notifications bot (May 12 2026 at 20:51):alexcrichton removed PR #13324 aarch64: Implement scalar ueq and one comparisons from the merge queue.
Wasmtime GitHub notifications bot (May 12 2026 at 20:51)::check: alexcrichton merged PR #13324.
Last updated: Jun 01 2026 at 09:49 UTC