Stream: git-wasmtime

Topic: wasmtime / PR #1330 github ci: disable fail-fast in Test ...

Wasmtime GitHub notifications bot (Mar 16 2020 at 19:40):

pchickey opened PR #1330 from pch/ci_no_fail_fast to master:

There appear to be some failures on the Test workflow on nightly, and perhaps elsewhere. Currently, the first job to fail in the Test job cancels all the others. Setting fail-fast to false will disable that behavior, so we can determine if its only nightly thats failing or some deeper issue.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 16 2020 at 19:40):

pchickey requested alexcrichton for a review on PR #1330.

Wasmtime GitHub notifications bot (Mar 16 2020 at 19:53):

pchickey updated PR #1330 from pch/ci_no_fail_fast to master:

There appear to be some failures on the Test workflow on nightly, and perhaps elsewhere. Currently, the first job to fail in the Test job cancels all the others. Setting fail-fast to false will disable that behavior, so we can determine if its only nightly thats failing or some deeper issue.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 17 2020 at 16:41):

alexcrichton closed without merge PR #1330.

Last updated: Nov 22 2024 at 17:03 UTC