Wasmtime GitHub notifications bot (May 04 2026 at 15:01): Wasmtime GitHub notifications bot (May 04 2026 at 15:01):theotherjimmy opened PR #13262 from theotherjimmy:s390x-rxsbg-range-end to bytecodealliance:main:
The bug this corrects is that the range specified by the rotate then <bool-op> select bits instructions is specified with an inclusive range start _and_ end. The prior implementation incorrectly specified the end of the range as if it were exclusive.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 04 2026 at 15:01):theotherjimmy requested wasmtime-compiler-s390x-reviewers for a review on PR #13262.
Wasmtime GitHub notifications bot (May 04 2026 at 15:07):alexcrichton requested uweigand for a review on PR #13262.
Wasmtime GitHub notifications bot (May 04 2026 at 15:41):uweigand commented on PR #13262:
The change LGTM as such, but you'll have to update the tests accordingly.
Ideally, we might want to have run-tests that would have caught this issue earlier ...
Wasmtime GitHub notifications bot (May 04 2026 at 16:41):theotherjimmy updated PR #13262.
Wasmtime GitHub notifications bot (May 04 2026 at 16:41):theotherjimmy requested wasmtime-compiler-reviewers for a review on PR #13262.
Wasmtime GitHub notifications bot (May 04 2026 at 16:42):theotherjimmy commented on PR #13262:
My bad, I forgot to turn my auto-testing back on. I've re-blessed the tests and confirmed that the only change is the end bit-address is reduced by one.
Wasmtime GitHub notifications bot (May 04 2026 at 17:08)::thumbs_up: uweigand submitted PR review:
LGTM, thanks!
Wasmtime GitHub notifications bot (May 04 2026 at 17:09):uweigand added PR #13262 s390x: correct off-by-one error in rotate then select insts to the merge queue.
Wasmtime GitHub notifications bot (May 04 2026 at 17:37)::check: uweigand merged PR #13262.
Wasmtime GitHub notifications bot (May 04 2026 at 17:37):uweigand removed PR #13262 s390x: correct off-by-one error in rotate then select insts from the merge queue.
Last updated: Jun 01 2026 at 09:49 UTC