Wasmtime GitHub notifications bot (Apr 29 2026 at 05:17): Wasmtime GitHub notifications bot (Apr 29 2026 at 05:17):RossComputerGuy requested fitzgen for a review on PR #13226.
Wasmtime GitHub notifications bot (Apr 29 2026 at 05:17):RossComputerGuy requested wasmtime-compiler-reviewers for a review on PR #13226.
Wasmtime GitHub notifications bot (Apr 29 2026 at 05:17):RossComputerGuy opened PR #13226 from Midstall:fix/riscv64 to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->Tested this with a project I'm working on. This prevented me from cross compiling from aarch64 to riscv64.
Wasmtime GitHub notifications bot (Apr 29 2026 at 05:20):RossComputerGuy commented on PR #13226:
<img width="1616" height="256" alt="image" src="https://github.com/user-attachments/assets/3e785bb2-6c88-4109-a0c2-451fb1923087" />
Wat
Wasmtime GitHub notifications bot (Apr 29 2026 at 06:15)::memo: bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Apr 29 2026 at 06:15)::speech_balloon: bjorn3 created PR review comment:
This FIXME should be preserved on the wildcard arm.
Wasmtime GitHub notifications bot (Apr 29 2026 at 06:17):RossComputerGuy updated PR #13226.
Wasmtime GitHub notifications bot (Apr 29 2026 at 06:17)::memo: RossComputerGuy submitted PR review.
Wasmtime GitHub notifications bot (Apr 29 2026 at 06:17)::speech_balloon: RossComputerGuy created PR review comment:
Done
Wasmtime GitHub notifications bot (Apr 29 2026 at 09:03):bjorn3 commented on PR #13226:
There is a CODEOWNER file that causes a team to be assigned automatically depending on the changed files. And when a team gets assigned, the assignment gets replaced with an assignment of a single member of this team. The CODEOWNER review assignment is attributed you as creator of the PR and the team member assignment is probably attributed to the person who did the team assignment, which according to the previous rule is considered you. It doesn't matter that you don't actually have permission to assign a reviewer. Perhaps github should have attributed the CODEOWNER assignment to a system user, but they didn't.
Wasmtime GitHub notifications bot (Apr 29 2026 at 12:07):github-actions[bot] added the label cranelift on PR #13226.
Wasmtime GitHub notifications bot (Apr 29 2026 at 12:07):github-actions[bot] added the label cranelift:module on PR #13226.
Wasmtime GitHub notifications bot (Apr 29 2026 at 13:05)::thumbs_up: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 29 2026 at 13:05):alexcrichton added PR #13226 Implement RiscvPCRelHi20 relocation in cranelift-object to the merge queue.
Wasmtime GitHub notifications bot (Apr 29 2026 at 13:30)::check: alexcrichton merged PR #13226.
Wasmtime GitHub notifications bot (Apr 29 2026 at 13:30):alexcrichton removed PR #13226 Implement RiscvPCRelHi20 relocation in cranelift-object from the merge queue.
Last updated: May 03 2026 at 22:13 UTC
