Stream: git-wasmtime

Topic: wasmtime / PR #13210 Fix some minor mistakes/typos in `gu...

Wasmtime GitHub notifications bot (Apr 27 2026 at 19:26):

alexcrichton requested dicej for a review on PR #13210.

Wasmtime GitHub notifications bot (Apr 27 2026 at 19:26):

alexcrichton requested wasmtime-core-reviewers for a review on PR #13210.

Wasmtime GitHub notifications bot (Apr 27 2026 at 19:26):

alexcrichton opened PR #13210 from alexcrichton:fix-guest-write to bytecodealliance:main:

This commit fixes a mistake where if a synchronous call to future.write was blocked, then it woke up because the readable end was dropped, the future would then erroneously not be marked "done" which could allow future operations to proceed. The fix here is to adjust a matches! to handle both futures and streams.

An associated *.wast test is expanded to mix in synchronous calls as well as asynchronous calls in various places. The test is refactored a bit to have various helpers in various places.

Finally some minor updates to error messages are made which avoids saying "stream" when the error shows up for both futures and streams.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 27 2026 at 20:10):

alexcrichton updated PR #13210.

Wasmtime GitHub notifications bot (Apr 27 2026 at 21:32):

:thumbs_up: dicej submitted PR review.

Wasmtime GitHub notifications bot (Apr 27 2026 at 21:37):

alexcrichton added PR #13210 Fix some minor mistakes/typos in guest_write to the merge queue

Wasmtime GitHub notifications bot (Apr 27 2026 at 22:00):

:check: alexcrichton merged PR #13210.

Wasmtime GitHub notifications bot (Apr 27 2026 at 22:00):

alexcrichton removed PR #13210 Fix some minor mistakes/typos in guest_write from the merge queue

Last updated: May 03 2026 at 22:13 UTC