Stream: git-wasmtime

Topic: wasmtime / PR #13205 [Cranelift] fix e-graph rewrite dept...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2026 at 04:35):

myunbin opened PR #13205 from myunbin:fix_e-graph_rewrite_depth_limit to bytecodealliance:main:

Fix an off-by-one in the e-graph rewrite depth limit.

REWRITE_LIMIT is set to 5. Current check uses rewrite_depth > REWRITE_LIMIT before incrementing the depth. Since
rewrite_depth starts at 0, this allows rewrites to run at effective depth 6.

If the intended maximum rewrite depth is 5, this changes the check to rewrite_depth >= REWRITE_LIMIT.

Noticed while investigating #13204.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2026 at 04:35):

myunbin requested fitzgen for a review on PR #13205.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2026 at 04:35):

myunbin requested wasmtime-compiler-reviewers for a review on PR #13205.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2026 at 04:59):

myunbin requested wasmtime-core-reviewers for a review on PR #13205.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2026 at 04:59):

myunbin updated PR #13205.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2026 at 08:32):

github-actions[bot] added the label cranelift on PR #13205.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2026 at 17:29):

:thumbs_up: fitzgen submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2026 at 17:30):

fitzgen added PR #13205 [Cranelift] fix e-graph rewrite depth limit to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2026 at 18:17):

:check: fitzgen merged PR #13205.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2026 at 18:17):

fitzgen removed PR #13205 [Cranelift] fix e-graph rewrite depth limit from the merge queue.

Last updated: May 03 2026 at 22:13 UTC