Wasmtime GitHub notifications bot (Mar 16 2020 at 16:26): Wasmtime GitHub notifications bot (Mar 16 2020 at 16:26):abrown edited PR #1319 from fix-simd-types to master:
This is fixing up some unfinished parts of the bitcasting approach discussed in #1147. The commit messages have more details (many more details) but the bottom line is that without a new type representing Wasm's
v128, cranelift needs someraw_bitcastinstructions strategically placed in order to type-check. This adds a few more of thoseraw_bitcasts.
Wasmtime GitHub notifications bot (Mar 17 2020 at 16:39):abrown updated PR #1319 from fix-simd-types to master:
This is fixing up some unfinished parts of the bitcasting approach discussed in #1147. The commit messages have more details (many more details) but the bottom line is that without a new type representing Wasm's
v128, cranelift needs someraw_bitcastinstructions strategically placed in order to type-check. This adds a few more of thoseraw_bitcasts.
Wasmtime GitHub notifications bot (Mar 17 2020 at 17:20):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Mar 17 2020 at 17:20):sunfishcode created PR Review Comment:
Please capitalize the first word of a sentence in a comment, and end it with a period if appropriate, as it is here.
Wasmtime GitHub notifications bot (Mar 17 2020 at 17:20):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Mar 17 2020 at 17:54):abrown updated PR #1319 from fix-simd-types to master:
This is fixing up some unfinished parts of the bitcasting approach discussed in #1147. The commit messages have more details (many more details) but the bottom line is that without a new type representing Wasm's
v128, cranelift needs someraw_bitcastinstructions strategically placed in order to type-check. This adds a few more of thoseraw_bitcasts.
Wasmtime GitHub notifications bot (Mar 17 2020 at 18:44):abrown merged PR #1319.
Last updated: Oct 23 2024 at 20:03 UTC