Stream: git-wasmtime

Topic: wasmtime / PR #13187 Refactor internals of `PassiveElemen...

Wasmtime GitHub notifications bot (Apr 24 2026 at 14:19):

alexcrichton requested fitzgen for a review on PR #13187.

Wasmtime GitHub notifications bot (Apr 24 2026 at 14:19):

alexcrichton opened PR #13187 from alexcrichton:follow-up to bytecodealliance:main:

In looking over #13179 I found it a bit brittle to access anyref fields unconditionally where the determination that the type of the segment was a GC reference was made much further away. I also found it somewhat confusing to have methods like clone_gc_ref and drop_gc_ref applied to all values which happened to be noops for non-gc-ref types. I've refactored things a bit internally here to plumb a WasmRefType around and have additionally added comments to why anyref accessors are used despite the value possibly having an exnref or externref type.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 24 2026 at 14:19):

alexcrichton requested wasmtime-core-reviewers for a review on PR #13187.

Wasmtime GitHub notifications bot (Apr 24 2026 at 15:23):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 24 2026 at 15:23):

fitzgen added PR #13187 Refactor internals of PassiveElementSegment to the merge queue

Wasmtime GitHub notifications bot (Apr 24 2026 at 15:50):

github-merge-queue[bot] removed PR #13187 Refactor internals of PassiveElementSegment from the merge queue

Wasmtime GitHub notifications bot (Apr 24 2026 at 15:56):

alexcrichton added PR #13187 Refactor internals of PassiveElementSegment to the merge queue

Wasmtime GitHub notifications bot (Apr 24 2026 at 16:22):

alexcrichton merged PR #13187.

Wasmtime GitHub notifications bot (Apr 24 2026 at 16:22):

alexcrichton removed PR #13187 Refactor internals of PassiveElementSegment from the merge queue

Last updated: May 03 2026 at 22:13 UTC