Wasmtime GitHub notifications bot (Mar 13 2020 at 21:57): Wasmtime GitHub notifications bot (Mar 13 2020 at 21:57):abrown opened PR #1318 from remove-fpr32 to master:
Until #1306 is resolved (some spilling/regalloc issue with larger FPR register banks), this removes FPR32 support. Only Wasm's
i64x2.mulwas using this register class and that instruction is predicated on AVX512 support; for the time being, that instruction will have to make do with the 16 FPR registers.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 13 2020 at 21:57):abrown requested alexcrichton for a review on PR #1318.
Wasmtime GitHub notifications bot (Mar 13 2020 at 22:00):iximeow submitted PR Review.
Wasmtime GitHub notifications bot (Mar 13 2020 at 22:02):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 13 2020 at 22:02):bjorn3 created PR Review Comment:
FIXME set back to 32 when FPR32 is re-added
Wasmtime GitHub notifications bot (Mar 13 2020 at 22:02):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 13 2020 at 22:05):abrown submitted PR Review.
Wasmtime GitHub notifications bot (Mar 13 2020 at 22:05):abrown created PR Review Comment:
I don't think I need to remind myself where to expand the register bank...
Wasmtime GitHub notifications bot (Mar 13 2020 at 23:01):abrown updated PR #1318 from remove-fpr32 to master:
Until #1306 is resolved (some spilling/regalloc issue with larger FPR register banks), this removes FPR32 support. Only Wasm's
i64x2.mulwas using this register class and that instruction is predicated on AVX512 support; for the time being, that instruction will have to make do with the 16 FPR registers.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 13 2020 at 23:03):abrown submitted PR Review.
Wasmtime GitHub notifications bot (Mar 13 2020 at 23:03):abrown created PR Review Comment:
@alexcrichton, I shouldn't need to assert anything here, right? Wasmtime will still attempt to compile this inside
module(...)?
Wasmtime GitHub notifications bot (Mar 13 2020 at 23:07):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 13 2020 at 23:07):alexcrichton created PR Review Comment:
I believe so yeah, but it might be good to double-check by running the tests before this PR as well to make sure this test fails.
Wasmtime GitHub notifications bot (Mar 17 2020 at 16:38):abrown updated PR #1318 from remove-fpr32 to master:
Until #1306 is resolved (some spilling/regalloc issue with larger FPR register banks), this removes FPR32 support. Only Wasm's
i64x2.mulwas using this register class and that instruction is predicated on AVX512 support; for the time being, that instruction will have to make do with the 16 FPR registers.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 17 2020 at 16:50):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 17 2020 at 18:46):abrown updated PR #1318 from remove-fpr32 to master:
Until #1306 is resolved (some spilling/regalloc issue with larger FPR register banks), this removes FPR32 support. Only Wasm's
i64x2.mulwas using this register class and that instruction is predicated on AVX512 support; for the time being, that instruction will have to make do with the 16 FPR registers.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 17 2020 at 19:46):abrown merged PR #1318.
Last updated: Dec 23 2024 at 13:07 UTC