darinmorrison opened PR #1317 from add-editorconfig
to master
:
This PR adds a basic EditorConfig file.
bjorn3 submitted PR Review.
bjorn3 created PR Review Comment:
Why 2?
bjorn3 submitted PR Review.
darinmorrison submitted PR Review.
darinmorrison created PR Review Comment:
No particular reason, just seems to be a popular choice. Some of the
.c
files seem to be using 2 spaces (example) and some of the.wat
files also use 2 spaces (example). However, sometimes there is an inconsistent mix of 2 and 4 spaces (example).I think it would be fine to leave
indent_size
unset if the choice is controversial.
sunfishcode submitted PR Review.
sunfishcode created PR Review Comment:
I think either way is fine. Our plan is to rewrite the remaining handful of .cpp files into Rust anyway :-).
darinmorrison closed without merge PR #1317.
Last updated: Dec 23 2024 at 12:05 UTC