Stream: git-wasmtime

Topic: wasmtime / PR #1317 Add .editorconfig

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 21:10):

darinmorrison opened PR #1317 from add-editorconfig to master:

This PR adds a basic EditorConfig file.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 21:26):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 21:26):

bjorn3 created PR Review Comment:

Why 2?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 21:26):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2020 at 19:05):

darinmorrison submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2020 at 19:05):

darinmorrison created PR Review Comment:

No particular reason, just seems to be a popular choice. Some of the .c files seem to be using 2 spaces (example) and some of the .wat files also use 2 spaces (example). However, sometimes there is an inconsistent mix of 2 and 4 spaces (example).

I think it would be fine to leave indent_size unset if the choice is controversial.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2020 at 23:08):

sunfishcode submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2020 at 23:08):

sunfishcode created PR Review Comment:

I think either way is fine. Our plan is to rewrite the remaining handful of .cpp files into Rust anyway :-).

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2020 at 20:59):

darinmorrison closed without merge PR #1317.

Last updated: Nov 22 2024 at 17:03 UTC