Stream: git-wasmtime

Topic: wasmtime / PR #13167 Wizer: rust regex test working as a ...

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:19):

pchickey opened PR #13167 from pchickey:pch/wizer_test_component_regex to bytecodealliance:main.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:21):

pchickey edited PR #13167:

Previously, the Wizer test suite tested the rust_regex crate as a Rust source built fixture as a module only. This PR tests it as a component as well.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:23):

pchickey edited PR #13167:

Previously, the Wizer test suite tested the regex-test crate as a Rust source built fixture as a module only. This PR tests it as a component as well.

• The regex-test crate was a member of the workspace, and was built via ~Command::new("cargo build ...") in a particular integration test. This architecture was an artifact of porting the wizer source into wasmtime from a separate repository. This PR moves the relevant code to a test-programs binary wizer_regex, and the integration test for the module uses it via test-programs-artifacts instead of building it directly.
  

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:32):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:32):

alexcrichton created PR review comment:

I think this isn't actually referred to anywhere else so it might be reasonable to use inline and put it here directly?

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:32):

alexcrichton created PR review comment:

Mind filing a bug for this? This, in theory, shouldn't be required

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:33):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:33):

pchickey created PR review comment:

Ah yeah I never got around to using wasmtime bindgen in the test harness, because it seemed like extra noise, so I'll inline it

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:33):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:33):

pchickey created PR review comment:

Already done, just hadnt pushed the FIXME comment yet

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:34):

pchickey updated PR #13167.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:36):

pchickey edited PR #13167:

Previously, the Wizer test suite tested the regex-test crate as a Rust source built fixture as a module only. This PR tests it as a component as well.

• The regex-test crate was a member of the workspace, and was built via ~Command::new("cargo build ...") in a particular integration test. This architecture was an artifact of porting the wizer source into wasmtime from a separate repository. This PR moves the relevant code to a test-programs binary wizer_regex, and the integration test for the module uses it via test-programs-artifacts instead of building it directly.

• The wizer_regex binary is built by test-programs-artifacts into both a wasip1 module, and a wasip2 component (via the adapter). Because the module's export names would shadow the component's export names, the module testing path gets module- prefixes on wizer-initialize and run, and the test harness is adjusted for this

• The wizer_regex export for run is func(arg: u32) -> u32 but the component tests written in wat were all run: func() -> u32, so all of the wat components were modified to take an arg: u32 param that they did nothing with.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:38):

pchickey updated PR #13167.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:39):

pchickey edited PR #13167:

Previously, the Wizer test suite tested the regex-test crate as a Rust source built fixture as a module only. This PR tests it as a component as well.

• The regex-test crate was a member of the workspace, and was built via ~Command::new("cargo build ...") in a particular integration test. This architecture was an artifact of porting the wizer source into wasmtime from a separate repository. This PR moves the relevant code to a test-programs binary wizer_regex, and the integration test for the module uses it via test-programs-artifacts instead of building it directly.

• The wizer_regex binary is built by test-programs-artifacts into both a wasip1 module, and a wasip2 component (via the adapter). Because the module's export names would shadow the component's export names, the module testing path gets module- prefixes on wizer-initialize and run, and the module integration test is adjusted so that this tweak can get fed in at the right places.

• The wizer_regex export for run is func(arg: u32) -> u32 but the component tests written in wat were all run: func() -> u32, so all of the wat components were modified to take an arg: u32 param that they did nothing with.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:39):

pchickey has marked PR #13167 as ready for review.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:39):

pchickey requested fitzgen for a review on PR #13167.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:39):

pchickey requested wasmtime-core-reviewers for a review on PR #13167.

Wasmtime GitHub notifications bot (Apr 21 2026 at 21:39):

pchickey requested wasmtime-default-reviewers for a review on PR #13167.

Wasmtime GitHub notifications bot (Apr 21 2026 at 22:06):

pchickey added PR #13167 Wizer: rust regex test working as a component to the merge queue.

Wasmtime GitHub notifications bot (Apr 21 2026 at 22:31):

pchickey merged PR #13167.

Wasmtime GitHub notifications bot (Apr 21 2026 at 22:31):

pchickey removed PR #13167 Wizer: rust regex test working as a component from the merge queue.

Last updated: May 03 2026 at 22:13 UTC