Wasmtime GitHub notifications bot (Apr 21 2026 at 18:17): Wasmtime GitHub notifications bot (Apr 21 2026 at 18:17):fitzgen opened PR #13165 from fitzgen:issue-13141 to bytecodealliance:main:
Because we lazily allocate the GC heap, it can always do one "move" from null to non-null, even if it cannot move otherwise after that.
Also allow specifying
flags = ...in.wasttests.Fixes #13141
Fixes #13134<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 21 2026 at 18:17):fitzgen requested dicej for a review on PR #13165.
Wasmtime GitHub notifications bot (Apr 21 2026 at 18:17):fitzgen requested wasmtime-core-reviewers for a review on PR #13165.
Wasmtime GitHub notifications bot (Apr 21 2026 at 18:29):alexcrichton created PR review comment:
What's up with this?
Wasmtime GitHub notifications bot (Apr 21 2026 at 18:29):alexcrichton submitted PR review:
W.r.t.
flags = "..."within*.wast, I'm not opposed but it'll need plumbing through to fuzzing as well where*.wasttests are running with different permutations of flags. That may be relatively difficult to plumb without a sort of "union" operation between to flags-for-config which feels a bit overweight for this. Alternatively though this could be added as a*.wasttest and it'll naturally get tested with various permutations of flags, and then this could additionally have atests/all/*.rstest which sets the specific flags for the regression
Wasmtime GitHub notifications bot (Apr 21 2026 at 18:55):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Apr 21 2026 at 18:55):fitzgen created PR review comment:
The wast pooling logic sets different tunables from the GC heap options, so things start breaking. And there isn't a great way to do the unioning of options because we don't expose getters on
wasmtime::Config. I'll just rip that stuff out I guess.
Wasmtime GitHub notifications bot (Apr 21 2026 at 19:09):fitzgen updated PR #13165.
Wasmtime GitHub notifications bot (Apr 21 2026 at 19:13):fitzgen requested alexcrichton for a review on PR #13165.
Wasmtime GitHub notifications bot (Apr 21 2026 at 19:26):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 21 2026 at 19:26):alexcrichton added PR #13165 Always emit code assuming the GC heap base might be relocated to the merge queue.
Wasmtime GitHub notifications bot (Apr 21 2026 at 20:07):alexcrichton merged PR #13165.
Wasmtime GitHub notifications bot (Apr 21 2026 at 20:07):alexcrichton removed PR #13165 Always emit code assuming the GC heap base might be relocated from the merge queue.
Last updated: May 03 2026 at 22:13 UTC