Wasmtime GitHub notifications bot (Apr 21 2026 at 17:43): Wasmtime GitHub notifications bot (Apr 21 2026 at 17:43):theotherjimmy opened PR #13164 from theotherjimmy:s390x-remove-has-type to bytecodealliance:main:
Since #12717 was merged, Types parameters are included in clif instructions and it is possible to match types without has_type. This is a follow up to that PR, as suggested in its description.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 21 2026 at 17:43):theotherjimmy requested wasmtime-compiler-s390x-reviewers for a review on PR #13164.
Wasmtime GitHub notifications bot (Apr 21 2026 at 17:51):alexcrichton requested uweigand for a review on PR #13164.
Wasmtime GitHub notifications bot (Apr 21 2026 at 21:01):github-actions[bot] added the label cranelift on PR #13164.
Wasmtime GitHub notifications bot (Apr 22 2026 at 11:48):uweigand submitted PR review:
This generally LGTM and is a nice simplification. I just noticed a couple of odd whitespace changes; would be good to fix those before merging.
Wasmtime GitHub notifications bot (Apr 22 2026 at 11:48):uweigand created PR review comment:
Please re-indent the second line as approriate as well.
Wasmtime GitHub notifications bot (Apr 22 2026 at 11:48):uweigand created PR review comment:
Extra whitespace.
Wasmtime GitHub notifications bot (Apr 22 2026 at 11:48):uweigand created PR review comment:
Extra whitespace.
Wasmtime GitHub notifications bot (Apr 22 2026 at 11:48):uweigand created PR review comment:
Extra whitespace here and in subsequent rules.
Wasmtime GitHub notifications bot (Apr 22 2026 at 16:48):theotherjimmy updated PR #13164.
Wasmtime GitHub notifications bot (Apr 22 2026 at 17:12):uweigand submitted PR review:
LGTM, thanks!
Wasmtime GitHub notifications bot (Apr 22 2026 at 17:12):uweigand added PR #13164 s390x: Remove most uses of has_type to the merge queue.
Last updated: May 03 2026 at 22:13 UTC