Stream: git-wasmtime

Topic: wasmtime / PR #13131 Mach-O: Set `LC_BUILD_VERSION`

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2026 at 13:20):

madsmtm opened PR #13131 from madsmtm:macho-build-version to bytecodealliance:main:

Fixes https://github.com/bytecodealliance/wasmtime/issues/8730, the remaining linker warnings are now gone.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2026 at 13:20):

madsmtm requested alexcrichton for a review on PR #13131.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2026 at 13:20):

madsmtm requested wasmtime-compiler-reviewers for a review on PR #13131.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2026 at 13:24):

madsmtm edited PR #13131:

Fixes https://github.com/bytecodealliance/wasmtime/issues/8730, the remaining linker warnings are now gone.

See also https://github.com/rust-lang/rustc_codegen_cranelift/pull/1645 which passes the actual version (instead of just specifying 0.0.0).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2026 at 14:26):

alexcrichton commented on PR #13131:

@bjorn3 would you be willing to review?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2026 at 17:59):

github-actions[bot] added the label cranelift:module on PR #13131.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2026 at 17:59):

github-actions[bot] added the label cranelift:area:aarch64 on PR #13131.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2026 at 17:59):

github-actions[bot] added the label cranelift on PR #13131.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 18 2026 at 14:24):

bjorn3 commented on PR #13131:

Looks fine to me, but CI fails.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 19 2026 at 11:42):

madsmtm updated PR #13131.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 19 2026 at 11:42):

madsmtm requested wasmtime-default-reviewers for a review on PR #13131.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 19 2026 at 11:47):

madsmtm updated PR #13131.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 19 2026 at 11:51):

madsmtm commented on PR #13131:

Had to update the target-lexicon dependency (I was testing this inside rustc_codegen_cranelift). I went with 0.13.3 as that seemed to be accepted by cargo vet.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 19 2026 at 11:52):

madsmtm commented on PR #13131:

A bit odd though, the "CI / Cargo vet failed on a Pull Request" step is failing, but "CI / Cargo vet" succeeds?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 19 2026 at 11:54):

madsmtm updated PR #13131.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 19 2026 at 12:21):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2026 at 14:24):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2026 at 14:24):

alexcrichton added PR #13131 Mach-O: Set LC_BUILD_VERSION to the merge queue

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2026 at 16:53):

alexcrichton merged PR #13131.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2026 at 16:53):

alexcrichton removed PR #13131 Mach-O: Set LC_BUILD_VERSION from the merge queue

Last updated: May 03 2026 at 22:13 UTC