Stream: git-wasmtime

Topic: wasmtime / PR #1311 cranelift-{module, faerie}: minor imp...

Wasmtime GitHub notifications bot (Mar 13 2020 at 18:58):

pchickey opened PR #1311 from pch/cranelift_module_errors to master:

I updated faerie to always return the fully structured
ArtifactError type throughout its API. This PR makes sure we also return that structured
error type in the FaerieProduct methods.

I have also revised the cranelift_module::ModuleError::Backend error variant, which appears
to only be used by the faerie backend, to contain an anyhow::Error instead of a String. This
way we retain more error information without breaking the abstraction that cranelift-module
doesn't know anything specific (like types) from its backends.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 13 2020 at 18:58):

pchickey requested sunfishcode for a review on PR #1311.

Wasmtime GitHub notifications bot (Mar 13 2020 at 19:08):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 13 2020 at 19:08):

sunfishcode created PR Review Comment:

Would it be difficult to update wasmtime-cli/debug/obj to faerie 0.15.0 so that we're just using one version?

Wasmtime GitHub notifications bot (Mar 13 2020 at 19:08):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 13 2020 at 22:09):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Mar 13 2020 at 22:09):

pchickey created PR Review Comment:

Sorry, I failed to grep for these. Will fix them all right now!

Wasmtime GitHub notifications bot (Mar 13 2020 at 22:31):

pchickey updated PR #1311 from pch/cranelift_module_errors to master:

I updated faerie to always return the fully structured
ArtifactError type throughout its API. This PR makes sure we also return that structured
error type in the FaerieProduct methods.

I have also revised the cranelift_module::ModuleError::Backend error variant, which appears
to only be used by the faerie backend, to contain an anyhow::Error instead of a String. This
way we retain more error information without breaking the abstraction that cranelift-module
doesn't know anything specific (like types) from its backends.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 13 2020 at 22:31):

pchickey requested sunfishcode for a review on PR #1311.

Wasmtime GitHub notifications bot (Mar 16 2020 at 18:56):

pchickey updated PR #1311 from pch/cranelift_module_errors to master:

I updated faerie to always return the fully structured
ArtifactError type throughout its API. This PR makes sure we also return that structured
error type in the FaerieProduct methods.

I have also revised the cranelift_module::ModuleError::Backend error variant, which appears
to only be used by the faerie backend, to contain an anyhow::Error instead of a String. This
way we retain more error information without breaking the abstraction that cranelift-module
doesn't know anything specific (like types) from its backends.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 17 2020 at 16:44):

pchickey updated PR #1311 from pch/cranelift_module_errors to master:

I updated faerie to always return the fully structured
ArtifactError type throughout its API. This PR makes sure we also return that structured
error type in the FaerieProduct methods.

I have also revised the cranelift_module::ModuleError::Backend error variant, which appears
to only be used by the faerie backend, to contain an anyhow::Error instead of a String. This
way we retain more error information without breaking the abstraction that cranelift-module
doesn't know anything specific (like types) from its backends.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 17 2020 at 17:55):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 17 2020 at 17:56):

pchickey merged PR #1311.

Last updated: Dec 23 2024 at 12:05 UTC