fitzgen opened PR #13093 from fitzgen:skeleton-of-copying-collector to bytecodealliance:main:
This commit adds the skeleton of a new copying collector, guarded behind a new "gc-copying" cargo feature. It compiles and implements the various
Gc*traits to interface with the runtime and compiler, but is not yet actually functional.The copying collector is intentionally excluded from the fuzzing config generator, as it isn't ready to be fuzzed yet.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen requested wasmtime-compiler-reviewers for a review on PR #13093.
fitzgen requested alexcrichton for a review on PR #13093.
fitzgen requested wasmtime-core-reviewers for a review on PR #13093.
fitzgen requested wasmtime-default-reviewers for a review on PR #13093.
fitzgen edited PR #13093:
This commit adds the skeleton of a new copying collector, guarded behind a new "gc-copying" cargo feature. It compiles and implements the various
Gc*traits to interface with the runtime and compiler, but is not yet actually functional.The copying collector is intentionally excluded from the fuzzing config generator, as it isn't ready to be fuzzed yet.
cc https://github.com/bytecodealliance/wasmtime/issues/10329
fitzgen requested uweigand for a review on PR #13093.
github-actions[bot] added the label wasmtime:api on PR #13093.
github-actions[bot] added the label wasmtime:c-api on PR #13093.
github-actions[bot] added the label wasmtime:ref-types on PR #13093.
github-actions[bot] added the label wasmtime:config on PR #13093.
github-actions[bot] added the label winch on PR #13093.
github-actions[bot] commented on PR #13093:
Subscribe to Label Action
cc @fitzgen, @saulecabrera
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:c-api", "wasmtime:config", "wasmtime:ref-types", "winch"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
alexcrichton submitted PR review.
alexcrichton commented on PR #13093:
The copying collector is intentionally excluded from the fuzzing config generator, as it isn't ready to be fuzzed yet.
Would it makes sense to leave comments as FIXMEs pointing to a tracking issue in a few locations (like fuzzing, the default set of features, etc) where this should go once it's ready?
github-actions[bot] commented on PR #13093:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
fitzgen commented on PR #13093:
Would it makes sense to leave comments as FIXMEs pointing to a tracking issue in a few locations (like fuzzing, the default set of features, etc) where this should go once it's ready?
I have WIP fuzzing integration in some follow up work already so I don't think we need
FIXMEs in the code at this time? But making a checklist somewhere of what we want done before enabling GC by default would be good to have. I'll whip that up in a little bit.
fitzgen added PR #13093 Add skeleton copying collector to the merge queue.
github-merge-queue[bot] removed PR #13093 Add skeleton copying collector from the merge queue.
fitzgen added PR #13093 Add skeleton copying collector to the merge queue.
fitzgen merged PR #13093.
fitzgen removed PR #13093 Add skeleton copying collector from the merge queue.
Last updated: May 03 2026 at 22:13 UTC