Wasmtime GitHub notifications bot (Apr 14 2026 at 16:49): Wasmtime GitHub notifications bot (Apr 14 2026 at 16:49):alexcrichton opened PR #13092 from alexcrichton:fix-drop-deadlock to bytecodealliance:main:
This commit removes a now-older assertion when disposing of a guest task that all threads are empty. This assertion is hit in a situation where
TypedFunc::call_asyncis used where the guest can't be entered due to backpressure. The assertion is a bit dated now and originally this helper function handled reparenting, but that's all gone now too. This commit removes the assertion entirely meaning that in this situation the guest thread will "leak" into the host, but the store is locked down at that point anyway, so this is in theory reasonable.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 14 2026 at 16:49):alexcrichton requested wasmtime-core-reviewers for a review on PR #13092.
Wasmtime GitHub notifications bot (Apr 14 2026 at 16:49):alexcrichton requested pchickey for a review on PR #13092.
Wasmtime GitHub notifications bot (Apr 14 2026 at 16:56):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Apr 14 2026 at 18:27):alexcrichton added PR #13092 cm-async: Remove assertion when disposing a task to the merge queue.
Wasmtime GitHub notifications bot (Apr 14 2026 at 18:51):github-merge-queue[bot] removed PR #13092 cm-async: Remove assertion when disposing a task from the merge queue.
Wasmtime GitHub notifications bot (Apr 14 2026 at 19:04):github-actions[bot] added the label wasmtime:api on PR #13092.
Wasmtime GitHub notifications bot (Apr 14 2026 at 19:11):alexcrichton updated PR #13092.
Wasmtime GitHub notifications bot (Apr 14 2026 at 19:11):alexcrichton has enabled auto merge for PR #13092.
Wasmtime GitHub notifications bot (Apr 14 2026 at 19:24):alexcrichton added PR #13092 cm-async: Remove assertion when disposing a task to the merge queue.
Wasmtime GitHub notifications bot (Apr 14 2026 at 19:49):alexcrichton merged PR #13092.
Wasmtime GitHub notifications bot (Apr 14 2026 at 19:49):alexcrichton removed PR #13092 cm-async: Remove assertion when disposing a task from the merge queue.
Last updated: May 03 2026 at 22:13 UTC