Stream: git-wasmtime

Topic: wasmtime / PR #13083 Make component linker allocations fa...

Wasmtime GitHub notifications bot (Apr 13 2026 at 22:16):

fitzgen opened PR #13083 from fitzgen:component-linker-fallible-allocs to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 13 2026 at 22:16):

fitzgen requested dicej for a review on PR #13083.

Wasmtime GitHub notifications bot (Apr 13 2026 at 22:16):

fitzgen requested wasmtime-core-reviewers for a review on PR #13083.

Wasmtime GitHub notifications bot (Apr 13 2026 at 22:28):

alexcrichton submitted PR review:

Tests too?

Wasmtime GitHub notifications bot (Apr 13 2026 at 22:28):

alexcrichton created PR review comment:

I forget the exact purpose of this, but could this switch to StringPool? Otherwise the purpose of the Arc was to avoid cloning it when inserting into two lists which this is doing away with. I think though that StringPool probably subsumes this?

Wasmtime GitHub notifications bot (Apr 13 2026 at 22:45):

fitzgen commented on PR #13083:

Tests too?

I have a bunch of OOM tests coming in follow ups, but wanted to separate this into its own PR first so reviewers could focus on actual code changes.

I can pluck them out and and them to this PR if you prefer tho

Wasmtime GitHub notifications bot (Apr 13 2026 at 22:45):

fitzgen commented on PR #13083:

(Figured that existing tests passing was enough tire-kicking for this PR to land on its own)

Wasmtime GitHub notifications bot (Apr 13 2026 at 22:57):

fitzgen updated PR #13083.

Wasmtime GitHub notifications bot (Apr 13 2026 at 22:58):

fitzgen has enabled auto merge for PR #13083.

Wasmtime GitHub notifications bot (Apr 13 2026 at 23:00):

alexcrichton commented on PR #13083:

Nah no worries, so long as there's tests eventually :+1:

Wasmtime GitHub notifications bot (Apr 13 2026 at 23:11):

fitzgen added PR #13083 Make component linker allocations fallible to the merge queue.

Wasmtime GitHub notifications bot (Apr 13 2026 at 23:36):

fitzgen merged PR #13083.

Wasmtime GitHub notifications bot (Apr 13 2026 at 23:36):

fitzgen removed PR #13083 Make component linker allocations fallible from the merge queue.

Last updated: May 03 2026 at 22:13 UTC