Stream: git-wasmtime

Topic: wasmtime / PR #13069 Remove incorrect noop in unix stack ...

Wasmtime GitHub notifications bot (Apr 13 2026 at 15:30):

alexcrichton opened PR #13069 from alexcrichton:remove-wrong-noop to bytecodealliance:main:

This commit removes a call to commit_pages in the unix_stack_pool.rs file. This function is a noop on unix and the parameters passed in for this call were also incorrect if it actually needed to do something anyway. This is otherwise just distracting, so remove it.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 13 2026 at 15:30):

alexcrichton requested wasmtime-core-reviewers for a review on PR #13069.

Wasmtime GitHub notifications bot (Apr 13 2026 at 15:30):

alexcrichton requested fitzgen for a review on PR #13069.

Wasmtime GitHub notifications bot (Apr 13 2026 at 17:57):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 13 2026 at 17:57):

fitzgen added PR #13069 Remove incorrect noop in unix stack pool management to the merge queue.

Wasmtime GitHub notifications bot (Apr 13 2026 at 19:09):

github-actions[bot] added the label wasmtime:api on PR #13069.

Wasmtime GitHub notifications bot (Apr 13 2026 at 19:33):

github-merge-queue[bot] removed PR #13069 Remove incorrect noop in unix stack pool management from the merge queue.

Wasmtime GitHub notifications bot (Apr 13 2026 at 19:54):

alexcrichton added PR #13069 Remove incorrect noop in unix stack pool management to the merge queue.

Wasmtime GitHub notifications bot (Apr 13 2026 at 22:01):

alexcrichton removed PR #13069 Remove incorrect noop in unix stack pool management from the merge queue.

Wasmtime GitHub notifications bot (Apr 13 2026 at 22:01):

alexcrichton merged PR #13069.

Last updated: May 03 2026 at 22:13 UTC