Stream: git-wasmtime

Topic: wasmtime / PR #1305 Fill out API docs on `wasmtime::Module`

Wasmtime GitHub notifications bot (Mar 12 2020 at 20:48):

alexcrichton opened PR #1305 from module-docs to master:

Part of #1272

Wasmtime GitHub notifications bot (Mar 12 2020 at 20:48):

alexcrichton requested fitzgen for a review on PR #1305.

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:36):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:36):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:36):

fitzgen created PR Review Comment:

/// // Now we're using the WebAssembly text extension: `.wat`!
/// let module = Module::from_file(&store, "path/to/foo.wat")?;

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:36):

fitzgen created PR Review Comment:

    /// The `.wat` text format is also supported:

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:36):

fitzgen created PR Review Comment:

    /// Note that the text format is **not** accepted by this function:

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:36):

fitzgen created PR Review Comment:

    /// assert!(module.exports().is_empty());

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:36):

fitzgen created PR Review Comment:

    /// Or you can also pass in a string to be parsed as the wasm text

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:36):

fitzgen created PR Review Comment:

    /// When the exports are not empty, you can inspect each export:

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:36):

fitzgen created PR Review Comment:

/// // It also works with the text format!

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:41):

alexcrichton updated PR #1305 from module-docs to master:

Part of #1272

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:41):

alexcrichton merged PR #1305.

Last updated: Oct 23 2024 at 20:03 UTC