Wasmtime GitHub notifications bot (Apr 10 2026 at 20:02): Wasmtime GitHub notifications bot (Apr 10 2026 at 20:02):alexcrichton requested dicej for a review on PR #13041.
Wasmtime GitHub notifications bot (Apr 10 2026 at 20:02):alexcrichton opened PR #13041 from alexcrichton:remove-assertions to bytecodealliance:main:
The fix in #12570 forgot to remove some stray debug assertions about the parent of a subtask when it's cancelled/dropped. Due to index reuse the assertions happened to pass with the test added in #12570, so the test was updated to "spray" the table a bit to prevent reuse which triggers the assertions. The fix here is then to just remove the assertions as they're no longer necessary.
Closes #13024
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 10 2026 at 20:02):alexcrichton requested wasmtime-core-reviewers for a review on PR #13041.
Wasmtime GitHub notifications bot (Apr 10 2026 at 20:24):dicej submitted PR review.
Wasmtime GitHub notifications bot (Apr 10 2026 at 20:25):alexcrichton added PR #13041 Remove erroneous debug assertions about parent tasks to the merge queue.
Wasmtime GitHub notifications bot (Apr 10 2026 at 20:49):alexcrichton merged PR #13041.
Wasmtime GitHub notifications bot (Apr 10 2026 at 20:49):alexcrichton removed PR #13041 Remove erroneous debug assertions about parent tasks from the merge queue.
Last updated: Apr 13 2026 at 00:25 UTC