Stream: git-wasmtime

Topic: wasmtime / PR #13019 Correct 2 s390x Vector Evaluate bugs

Wasmtime GitHub notifications bot (Apr 09 2026 at 19:57):

theotherjimmy opened PR #13019 from theotherjimmy:s390x-veval-bug to bytecodealliance:main:

Bugs:
1) Argument swapping of vec eval lowerings corresponding to a and (not b) and c
2) Argument swapping (divisor and dividend reversed) of the sdiv overflow check using vec eval

I have added runtests for both of these bugs in their respective commits.

Thanks for reporting these bugs @shumbo !

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 09 2026 at 19:57):

theotherjimmy requested wasmtime-compiler-s390x-reviewers for a review on PR #13019.

Wasmtime GitHub notifications bot (Apr 09 2026 at 19:57):

theotherjimmy requested wasmtime-compiler-reviewers for a review on PR #13019.

Wasmtime GitHub notifications bot (Apr 09 2026 at 19:57):

theotherjimmy requested alexcrichton for a review on PR #13019.

Wasmtime GitHub notifications bot (Apr 09 2026 at 19:58):

alexcrichton unassigned alexcrichton from PR #13019 Correct 2 s390x Vector Evaluate bugs.

Wasmtime GitHub notifications bot (Apr 09 2026 at 19:58):

alexcrichton requested uweigand for a review on PR #13019.

Wasmtime GitHub notifications bot (Apr 09 2026 at 20:04):

theotherjimmy converted PR #13019 Correct 2 s390x Vector Evaluate bugs to a draft.

Wasmtime GitHub notifications bot (Apr 09 2026 at 20:05):

theotherjimmy commented on PR #13019:

My bad about the test failures. I'll fix them.

Wasmtime GitHub notifications bot (Apr 09 2026 at 20:09):

theotherjimmy updated PR #13019.

Wasmtime GitHub notifications bot (Apr 09 2026 at 20:09):

theotherjimmy has marked PR #13019 as ready for review.

Wasmtime GitHub notifications bot (Apr 09 2026 at 20:10):

theotherjimmy commented on PR #13019:

Test failures were related to having forgotten to bless the new precise compile output for these two bugs.

Wasmtime GitHub notifications bot (Apr 09 2026 at 23:54):

github-actions[bot] added the label cranelift on PR #13019.

Last updated: Apr 12 2026 at 23:10 UTC