alexcrichton requested wasmtime-core-reviewers for a review on PR #13008.
alexcrichton opened PR #13008 from alexcrichton:fix-pooling-allocator to bytecodealliance:main:
Note: this is a fix for GHSA-6wgr-89rj-399p
This commit fixes a mistake that was introduced in #9583 where the logic to reset a linear memory slot in the pooling allocator used the wrong predicate. Specifically VM permissions must be reset if virtual memory can be relied on at all, and the preexisting predicate of
can_elide_bounds_checkwas an inaccurate representation of this. The correct predicate to check iscan_use_virtual_memory.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested fitzgen for a review on PR #13008.
alexcrichton updated PR #13008.
fitzgen submitted PR review.
fitzgen added PR #13008 Fix pooling allocator predicate to reset VM permissions to the merge queue.
fitzgen merged PR #13008.
fitzgen removed PR #13008 Fix pooling allocator predicate to reset VM permissions from the merge queue.
Last updated: Apr 12 2026 at 23:10 UTC