Stream: git-wasmtime

Topic: wasmtime / PR #1299 [wiggle] Impl different formatters fo...

Wasmtime GitHub notifications bot (Mar 12 2020 at 10:17):

kubkon edited PR #1299 from wiggle-octat-hex-flags to master:

Rather than forcing only binary formatting of flags types, how about
we implement all relevant traits (Binary, Octal, LowerHex, and
UpperHex) and allow the user to pick the most relevant one for their
use case?

Also, we use at least Octal and LowerHex in a couple of places
in wasi-common.

Wasmtime GitHub notifications bot (Mar 12 2020 at 22:39):

kubkon updated PR #1299 from wiggle-octat-hex-flags to master:

Rather than forcing only binary formatting of flags types, how about
we implement all relevant traits (Binary, Octal, LowerHex, and
UpperHex) and allow the user to pick the most relevant one for their
use case?

Also, we use at least Octal and LowerHex in a couple of places
in wasi-common.

Wasmtime GitHub notifications bot (Mar 12 2020 at 22:42):

kubkon requested alexcrichton, pchickey, and sunfishcode for a review on PR #1299.

Wasmtime GitHub notifications bot (Mar 12 2020 at 23:29):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 13 2020 at 09:14):

kubkon updated PR #1299 from wiggle-octat-hex-flags to master:

Rather than forcing only binary formatting of flags types, how about
we implement all relevant traits (Binary, Octal, LowerHex, and
UpperHex) and allow the user to pick the most relevant one for their
use case?

Also, we use at least Octal and LowerHex in a couple of places
in wasi-common.

Wasmtime GitHub notifications bot (Mar 13 2020 at 09:19):

kubkon requested alexcrichton, pchickey, and sunfishcode for a review on PR #1299.

Wasmtime GitHub notifications bot (Mar 13 2020 at 10:21):

kubkon updated PR #1299 from wiggle-octat-hex-flags to master:

Rather than forcing only binary formatting of flags types, how about
we implement all relevant traits (Binary, Octal, LowerHex, and
UpperHex) and allow the user to pick the most relevant one for their
use case?

Also, we use at least Octal and LowerHex in a couple of places
in wasi-common.

Wasmtime GitHub notifications bot (Mar 13 2020 at 16:16):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Mar 13 2020 at 19:27):

sunfishcode merged PR #1299.

Last updated: Dec 23 2024 at 13:07 UTC