Stream: git-wasmtime

Topic: wasmtime / PR #1298 Increase the size of the sigaltstack.

Wasmtime GitHub notifications bot (Mar 12 2020 at 01:33):

sunfishcode opened PR #1298 from bigger-sigaltstack to master:

Rust's stack overflow handler installs a sigaltstack stack with size
SIGSTKSZ, which is too small for some of the things we do in signal
handlers. Install bigger sigaltstack stacks so that we have enough
space.

cc #900. The code here is a sketch of a possible
alternative. Advantages of this approach include not needing extra
prologue checks, not disabling the Rust stack overflow message, and
ensuring that we always have a guard page.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 12 2020 at 15:37):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Mar 12 2020 at 15:37):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Mar 12 2020 at 15:37):

alexcrichton created PR Review Comment:

Could this test be done before we start mmap'ing? We could check to see if the sigaltstack size is already big enough or if it's disabled then we we can act before we mmap our own and set it.

Wasmtime GitHub notifications bot (Mar 12 2020 at 15:37):

alexcrichton created PR Review Comment:

How come there's an OOM trap, but then this is an abort? Could this translate to a trap as well?

Wasmtime GitHub notifications bot (Mar 13 2020 at 21:03):

sunfishcode closed without merge PR #1298.

Last updated: Nov 22 2024 at 16:03 UTC