alexcrichton opened PR #12966 from alexcrichton:fix-intra-component-multi-memory-stream to bytecodealliance:main:
This commit fixes a mistake from #12872 where an intra-component copy of a stream/future payload incorrectly use a
copy_withinwhen different memories were in use. Previously instance identity was used to test whethercopy_withincan be used but the correct check is to use memory identity. This handles the case where a single component instance has multiple memories in use, for example.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested fitzgen for a review on PR #12966.
alexcrichton requested wasmtime-core-reviewers for a review on PR #12966.
alexcrichton unassigned fitzgen from PR #12966 Fix intra-component stream/futures copies with multi-memory.
alexcrichton requested dicej for a review on PR #12966.
alexcrichton updated PR #12966.
dicej submitted PR review.
alexcrichton added PR #12966 Fix intra-component stream/futures copies with multi-memory to the merge queue.
alexcrichton merged PR #12966.
alexcrichton removed PR #12966 Fix intra-component stream/futures copies with multi-memory from the merge queue.
Ari4ka submitted PR review.
Last updated: Apr 12 2026 at 23:10 UTC