Wasmtime GitHub notifications bot (Apr 03 2026 at 19:25): Wasmtime GitHub notifications bot (Apr 03 2026 at 19:25):alexcrichton requested fitzgen for a review on PR #12956.
Wasmtime GitHub notifications bot (Apr 03 2026 at 19:25):alexcrichton requested wasmtime-core-reviewers for a review on PR #12956.
Wasmtime GitHub notifications bot (Apr 03 2026 at 19:25):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #12956.
Wasmtime GitHub notifications bot (Apr 03 2026 at 19:25):alexcrichton opened PR #12956 from alexcrichton:rsicv64-fix-replicated-imm5 to bytecodealliance:main:
This commit fixes the
replicated_imm5lowering rule in the riscv64 backend when applied tovconstinputs. This is reachable in WebAssembly viav128.const, for example, or via Cranelift optimizations. The previous iteration of the rule did not take lane width into account and always reduced the immediate as much as possible where the reduction needed to halt once the lane size had been reached.The fix here is to refactor the definition to have a rule-per-lane-width which handles the input constant. This is accompanied with some minor refactorings around available ISLE rules and such to handle more bit widths in more locations, have more faithful signatures, etc.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 03 2026 at 21:52):github-actions[bot] added the label cranelift:area:aarch64 on PR #12956.
Wasmtime GitHub notifications bot (Apr 03 2026 at 21:52):github-actions[bot] added the label cranelift on PR #12956.
Wasmtime GitHub notifications bot (Apr 03 2026 at 23:17):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Apr 03 2026 at 23:46):alexcrichton added PR #12956 riscv64: Fix replicated_imm5 lowering rule to the merge queue.
Wasmtime GitHub notifications bot (Apr 04 2026 at 00:10):github-merge-queue[bot] removed PR #12956 riscv64: Fix replicated_imm5 lowering rule from the merge queue.
Wasmtime GitHub notifications bot (Apr 04 2026 at 00:30):alexcrichton updated PR #12956.
Wasmtime GitHub notifications bot (Apr 04 2026 at 00:30):alexcrichton has enabled auto merge for PR #12956.
Wasmtime GitHub notifications bot (Apr 04 2026 at 00:52):alexcrichton added PR #12956 riscv64: Fix replicated_imm5 lowering rule to the merge queue.
Wasmtime GitHub notifications bot (Apr 04 2026 at 01:15):github-merge-queue[bot] removed PR #12956 riscv64: Fix replicated_imm5 lowering rule from the merge queue.
Wasmtime GitHub notifications bot (Apr 06 2026 at 14:19):alexcrichton updated PR #12956.
Wasmtime GitHub notifications bot (Apr 06 2026 at 14:19):alexcrichton has enabled auto merge for PR #12956.
Wasmtime GitHub notifications bot (Apr 06 2026 at 14:43):alexcrichton added PR #12956 riscv64: Fix replicated_imm5 lowering rule to the merge queue.
Wasmtime GitHub notifications bot (Apr 06 2026 at 15:06):alexcrichton merged PR #12956.
Wasmtime GitHub notifications bot (Apr 06 2026 at 15:06):alexcrichton removed PR #12956 riscv64: Fix replicated_imm5 lowering rule from the merge queue.
Wasmtime GitHub notifications bot (Apr 06 2026 at 15:11):Ari4ka submitted PR review.
Last updated: Apr 12 2026 at 23:10 UTC