Stream: git-wasmtime

Topic: wasmtime / PR #12953 Add support for async tests to our O...

Wasmtime GitHub notifications bot (Apr 03 2026 at 18:08):

fitzgen opened PR #12953 from fitzgen:async-oom-tests to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 03 2026 at 18:08):

fitzgen requested alexcrichton for a review on PR #12953.

Wasmtime GitHub notifications bot (Apr 03 2026 at 18:08):

fitzgen requested wasmtime-fuzz-reviewers for a review on PR #12953.

Wasmtime GitHub notifications bot (Apr 03 2026 at 18:17):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 03 2026 at 18:17):

alexcrichton created PR review comment:

There's a crate::block_on function which may help replace this

Wasmtime GitHub notifications bot (Apr 03 2026 at 18:17):

alexcrichton created PR review comment:

I find the manipulation of OomState a bit confusing here, would it be possible to change ScopedOomState to take &mut OomState and hold on to it? That way it could mutate in-place and the management here would be (a) create ScopedOomState before poll and (b) drop it after poll.

For example I would expect this to be self.state = guard.finish(), and otherwise during Pending below it seems that the manual set_oom_state there is reading stale state since finish here already took the state.

Wasmtime GitHub notifications bot (Apr 03 2026 at 18:17):

alexcrichton created PR review comment:

s/impl Fn() -> F/impl AsyncFn() -> Result<()>/

Wasmtime GitHub notifications bot (Apr 03 2026 at 18:17):

alexcrichton created PR review comment:

Stray changes?

Wasmtime GitHub notifications bot (Apr 03 2026 at 18:49):

fitzgen updated PR #12953.

Wasmtime GitHub notifications bot (Apr 03 2026 at 18:50):

fitzgen has enabled auto merge for PR #12953.

Wasmtime GitHub notifications bot (Apr 03 2026 at 19:02):

fitzgen added PR #12953 Add support for async tests to our OOM test infrastructure to the merge queue.

Wasmtime GitHub notifications bot (Apr 03 2026 at 19:26):

fitzgen merged PR #12953.

Wasmtime GitHub notifications bot (Apr 03 2026 at 19:26):

fitzgen removed PR #12953 Add support for async tests to our OOM test infrastructure from the merge queue.

Last updated: Apr 12 2026 at 23:10 UTC