Wasmtime GitHub notifications bot (Mar 11 2020 at 21:19): Wasmtime GitHub notifications bot (Mar 11 2020 at 21:19):pchickey opened PR #1294 from pch/wiggle_relative_paths to master:
prior to this change, they were relative to CARGO_MANIFEST_DIR for the
wiggle-generate crate.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 11 2020 at 21:19):pchickey requested kubkon for a review on PR #1294.
Wasmtime GitHub notifications bot (Mar 11 2020 at 21:44):alexcrichton created PR Review Comment:
Is this intended to be
std::env::var? Otherwise it looks like paths will be relative to thewigglecrate, and I'm not sure if that's what's intended?
Wasmtime GitHub notifications bot (Mar 11 2020 at 21:44):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 11 2020 at 21:44):pchickey updated PR #1294 from pch/wiggle_relative_paths to master:
prior to this change, they were relative to CARGO_MANIFEST_DIR for the
wiggle-generate crate.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 11 2020 at 21:47):pchickey submitted PR Review.
Wasmtime GitHub notifications bot (Mar 11 2020 at 21:47):pchickey created PR Review Comment:
I think my push of that fix raced your review :)
Wasmtime GitHub notifications bot (Mar 11 2020 at 21:56):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 11 2020 at 23:03):pchickey merged PR #1294.
Last updated: Dec 23 2024 at 13:07 UTC