Stream: git-wasmtime

Topic: wasmtime / PR #1292 Temporarily remove support for interf...

Wasmtime GitHub notifications bot (Mar 11 2020 at 21:10):

alexcrichton opened PR #1292 from rm-interface-types to master:

This commit temporarily removes support for interface types from the
wasmtime CLI and removes the wasmtime-interface-types crate. An
error is now printed for any input wasm modules that have wasm interface
types sections to indicate that support has been removed and references
to two issues are printed as well:

• #677 - tracking work for re-adding interface types support
• #1271 - rationale for removal and links to other discussions

Closes #1271

Wasmtime GitHub notifications bot (Mar 11 2020 at 22:33):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Mar 11 2020 at 22:33):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Mar 11 2020 at 22:33):

fitzgen created PR Review Comment:

Support for interface types has temporarily been removed from `wasmtime`.

Wasmtime GitHub notifications bot (Mar 11 2020 at 22:33):

fitzgen created PR Review Comment:

For more information about why interface types are temporarily disabled, see this issue:

Wasmtime GitHub notifications bot (Mar 11 2020 at 22:33):

fitzgen created PR Review Comment:

and for information about re-enabling support for interface types, see this issue:

Wasmtime GitHub notifications bot (Mar 12 2020 at 15:50):

alexcrichton updated PR #1292 from rm-interface-types to master:

This commit temporarily removes support for interface types from the
wasmtime CLI and removes the wasmtime-interface-types crate. An
error is now printed for any input wasm modules that have wasm interface
types sections to indicate that support has been removed and references
to two issues are printed as well:

• #677 - tracking work for re-adding interface types support
• #1271 - rationale for removal and links to other discussions

Closes #1271

Wasmtime GitHub notifications bot (Mar 12 2020 at 19:13):

alexcrichton updated PR #1292 from rm-interface-types to master:

This commit temporarily removes support for interface types from the
wasmtime CLI and removes the wasmtime-interface-types crate. An
error is now printed for any input wasm modules that have wasm interface
types sections to indicate that support has been removed and references
to two issues are printed as well:

• #677 - tracking work for re-adding interface types support
• #1271 - rationale for removal and links to other discussions

Closes #1271

Wasmtime GitHub notifications bot (Mar 12 2020 at 20:05):

alexcrichton merged PR #1292.

Last updated: Oct 23 2024 at 20:03 UTC