wasmtime / PR #12915 Add support for `structref` to the C... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #12915 Add support for `structref` to the C...

Wasmtime GitHub notifications bot (Mar 31 2026 at 21:39):

fitzgen opened PR #12915 from fitzgen:add-structref-support-to-c-api to bytecodealliance:main:

Also requires adding support for struct and field types, as well as
StructRefPre.

Depends on https://github.com/bytecodealliance/wasmtime/pull/12914

Wasmtime GitHub notifications bot (Mar 31 2026 at 21:39):

fitzgen requested pchickey for a review on PR #12915.

Wasmtime GitHub notifications bot (Mar 31 2026 at 21:39):

fitzgen requested wasmtime-core-reviewers for a review on PR #12915.

Wasmtime GitHub notifications bot (Mar 31 2026 at 21:51):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 31 2026 at 21:51):

alexcrichton created PR review comment:

exnref?

Wasmtime GitHub notifications bot (Mar 31 2026 at 21:51):

alexcrichton created PR review comment:

s/c_ptr/capi/

(I think that's used elsewhere throughout).

Also, can this use the WASMTIME_OWN_WRAPPER helper macro? (and maybe some of the other helper macros in other places if applicable?)

Wasmtime GitHub notifications bot (Mar 31 2026 at 21:51):

alexcrichton created PR review comment:

It may also be worth making a macro for the GC types since they're all going to be quite similar.

Wasmtime GitHub notifications bot (Mar 31 2026 at 21:51):

alexcrichton created PR review comment:

bikeshed: WASMTIME_STORAGE_KIND_I8?

Wasmtime GitHub notifications bot (Mar 31 2026 at 22:53):

github-actions[bot] added the label wasmtime:api on PR #12915.

Wasmtime GitHub notifications bot (Mar 31 2026 at 22:53):

github-actions[bot] added the label wasmtime:ref-types on PR #12915.

Wasmtime GitHub notifications bot (Mar 31 2026 at 22:53):

github-actions[bot] added the label wasmtime:c-api on PR #12915.

Wasmtime GitHub notifications bot (Mar 31 2026 at 22:57):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 31 2026 at 22:57):

fitzgen created PR review comment:

Ah that didn't exist yet, I can rebase and add that here

Wasmtime GitHub notifications bot (Mar 31 2026 at 22:58):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 31 2026 at 22:58):

fitzgen created PR review comment:

There aren't that many GC types and the casts available is all going to defer, so I think I'll avoid a new macro for GC types

Wasmtime GitHub notifications bot (Mar 31 2026 at 23:52):

github-actions[bot] commented on PR #12915:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:c-api", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

fitzgen: wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>