Stream: git-wasmtime

Topic: wasmtime / PR #12900 gc_ops: Address assertion failure in...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 21:07):

khagankhan opened PR #12900 from khagankhan:assertion-failure-fix to bytecodealliance:main:

Fix Types::fixupto handle types appearing in multiple rec groups opened in #12892.

Libfuzzer mutations can place the same TypeId in more than one rec group. is_well_formed asserted against this but fixup never corrected it, causing a failure. Added a dedup pass that keeps each type in only the first group. Also simplified the orphan logic since we no longer need to distinguish corruption orphans from trimmed-group orphans. Added log info to the is_well_formed function to see the reason of failure.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 21:07):

khagankhan requested alexcrichton for a review on PR #12900.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 21:07):

khagankhan requested wasmtime-fuzz-reviewers for a review on PR #12900.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 21:07):

khagankhan edited PR #12900:

Fix Types::fixupto handle types appearing in multiple rec groups opened in #12892.

Libfuzzer mutations can place the same TypeId in more than one rec group. is_well_formed asserted against this but fixup never corrected it, causing a failure. Added a dedup pass that keeps each type in only the first group. Also simplified the orphan logic since we no longer need to distinguish corruption orphans from trimmed-group orphans. Added log info to the is_well_formed function to see the reason of failure.

cc @fitzgen

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 23:41):

alexcrichton unassigned alexcrichton from PR #12900 gc_ops: Address assertion failure in the types fixup().

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 23:41):

alexcrichton requested fitzgen for a review on PR #12900.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 23:42):

alexcrichton edited PR #12900:

Fix Types::fixupto handle types appearing in multiple rec groups opened in #12892.

Libfuzzer mutations can place the same TypeId in more than one rec group. is_well_formed asserted against this but fixup never corrected it, causing a failure. Added a dedup pass that keeps each type in only the first group. Also simplified the orphan logic since we no longer need to distinguish corruption orphans from trimmed-group orphans. Added log info to the is_well_formed function to see the reason of failure.

cc @fitzgen

Closes #12892

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2026 at 02:33):

github-actions[bot] added the label fuzzing on PR #12900.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2026 at 02:34):

github-actions[bot] commented on PR #12900:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2026 at 21:33):

fitzgen submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2026 at 21:33):

fitzgen added PR #12900 gc_ops: Address assertion failure in the types fixup() to the merge queue

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2026 at 21:57):

fitzgen merged PR #12900.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2026 at 21:57):

fitzgen removed PR #12900 gc_ops: Address assertion failure in the types fixup() from the merge queue

Last updated: Apr 12 2026 at 23:10 UTC