Stream: git-wasmtime

Topic: wasmtime / PR #1290 Add a first-class way of accessing ca...

Wasmtime GitHub notifications bot (Mar 11 2020 at 19:13):

alexcrichton opened PR #1290 from rewrite-func to master:

This commit is a continuation of #1237 and updates the API of Func to
allow defining host functions which have easy access to a caller's
memory in particular. The new APIs look like so:

• The Func::wrap* family of functions was condensed into one
  Func::wrap function.

• The ABI layer of conversions in WasmTy were removed

• An optional Caller<'_> argument can be at the front of all
  host-defined functions now.

The old way the wasi bindings looked up memory has been removed and is
now replaced with the Caller type. The Caller type has a
get_export method on it which allows looking up a caller's export by
name, allowing you to get access to the caller's memory easily, and even
during instantiation.

Wasmtime GitHub notifications bot (Mar 12 2020 at 19:47):

alexcrichton updated PR #1290 from rewrite-func to master:

This commit is a continuation of #1237 and updates the API of Func to
allow defining host functions which have easy access to a caller's
memory in particular. The new APIs look like so:

• The Func::wrap* family of functions was condensed into one
  Func::wrap function.

• The ABI layer of conversions in WasmTy were removed

• An optional Caller<'_> argument can be at the front of all
  host-defined functions now.

The old way the wasi bindings looked up memory has been removed and is
now replaced with the Caller type. The Caller type has a
get_export method on it which allows looking up a caller's export by
name, allowing you to get access to the caller's memory easily, and even
during instantiation.

Wasmtime GitHub notifications bot (Mar 12 2020 at 19:47):

alexcrichton requested sunfishcode for a review on PR #1290.

Wasmtime GitHub notifications bot (Mar 12 2020 at 21:34):

alexcrichton updated PR #1290 from rewrite-func to master:

This commit is a continuation of #1237 and updates the API of Func to
allow defining host functions which have easy access to a caller's
memory in particular. The new APIs look like so:

• The Func::wrap* family of functions was condensed into one
  Func::wrap function.

• The ABI layer of conversions in WasmTy were removed

• An optional Caller<'_> argument can be at the front of all
  host-defined functions now.

The old way the wasi bindings looked up memory has been removed and is
now replaced with the Caller type. The Caller type has a
get_export method on it which allows looking up a caller's export by
name, allowing you to get access to the caller's memory easily, and even
during instantiation.

Wasmtime GitHub notifications bot (Mar 18 2020 at 20:46):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 18 2020 at 20:46):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 18 2020 at 20:46):

sunfishcode created PR Review Comment:

It feels like this paragraph belongs on the struct rather than on the get_export method.

Wasmtime GitHub notifications bot (Mar 18 2020 at 20:46):

sunfishcode created PR Review Comment:

It'd be good to mention somewhere that this is intended to be a temporary mechanism, and that we're hoping interface types will provide better ways to do this in the future.

Wasmtime GitHub notifications bot (Mar 18 2020 at 21:09):

alexcrichton updated PR #1290 from rewrite-func to master:

This commit is a continuation of #1237 and updates the API of Func to
allow defining host functions which have easy access to a caller's
memory in particular. The new APIs look like so:

• The Func::wrap* family of functions was condensed into one
  Func::wrap function.

• The ABI layer of conversions in WasmTy were removed

• An optional Caller<'_> argument can be at the front of all
  host-defined functions now.

The old way the wasi bindings looked up memory has been removed and is
now replaced with the Caller type. The Caller type has a
get_export method on it which allows looking up a caller's export by
name, allowing you to get access to the caller's memory easily, and even
during instantiation.

Wasmtime GitHub notifications bot (Mar 18 2020 at 21:41):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 18 2020 at 21:57):

alexcrichton merged PR #1290.

Last updated: Nov 22 2024 at 16:03 UTC