Stream: git-wasmtime

Topic: wasmtime / PR #12886 Fix two off-by-one correctness issue...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 08:16):

alexcrichton requested wasmtime-core-reviewers for a review on PR #12886.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 08:16):

alexcrichton opened PR #12886 from alexcrichton:verify-big-string to bytecodealliance:main:

The first issue fixes here is that the maximum string byte length was one byte larger than the spec defines (1<<31 instead of (1<<31)-1). The second issue is that in the comparison against the maximum byte length >= was used where > should have been used. A test has been added which exercises these two cases.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 08:16):

alexcrichton requested fitzgen for a review on PR #12886.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 12:48):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 12:49):

fitzgen added PR #12886 Fix two off-by-one correctness issues in string transcoding to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 14:16):

fitzgen merged PR #12886.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2026 at 14:16):

fitzgen removed PR #12886 Fix two off-by-one correctness issues in string transcoding from the merge queue.


Last updated: Apr 12 2026 at 23:10 UTC