alexcrichton requested wasmtime-core-reviewers for a review on PR #12886.
alexcrichton opened PR #12886 from alexcrichton:verify-big-string to bytecodealliance:main:
The first issue fixes here is that the maximum string byte length was one byte larger than the spec defines (
1<<31instead of(1<<31)-1). The second issue is that in the comparison against the maximum byte length>=was used where>should have been used. A test has been added which exercises these two cases.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested fitzgen for a review on PR #12886.
fitzgen submitted PR review.
fitzgen added PR #12886 Fix two off-by-one correctness issues in string transcoding to the merge queue.
fitzgen merged PR #12886.
fitzgen removed PR #12886 Fix two off-by-one correctness issues in string transcoding from the merge queue.
Last updated: Apr 12 2026 at 23:10 UTC