Wasmtime GitHub notifications bot (Mar 30 2026 at 08:13): Wasmtime GitHub notifications bot (Mar 30 2026 at 08:13):alexcrichton opened PR #12882 from alexcrichton:fix-fact-length-calculation to bytecodealliance:main:
This fixes a calculation when the source memory and destination memory have different pointer sizes. A typo meant that the destination byte length used the source byte length by accident instead of the source length. This isn't actually reachable at all in wasm today because memory64 isn't available at this time for components. FACT was originally written with memory64 support, however, to be a bit more future-proof and the component model may be getting memory64 support soon. For now though there's no test for this, just a minor update.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 30 2026 at 08:13):alexcrichton requested pchickey for a review on PR #12882.
Wasmtime GitHub notifications bot (Mar 30 2026 at 08:13):alexcrichton requested wasmtime-core-reviewers for a review on PR #12882.
Wasmtime GitHub notifications bot (Mar 30 2026 at 17:20):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Mar 30 2026 at 17:22):alexcrichton added PR #12882 Fix a list length calculation in FACT-generated adapters to the merge queue.
Wasmtime GitHub notifications bot (Mar 30 2026 at 20:47):alexcrichton merged PR #12882.
Wasmtime GitHub notifications bot (Mar 30 2026 at 20:47):alexcrichton removed PR #12882 Fix a list length calculation in FACT-generated adapters from the merge queue.
Last updated: Apr 12 2026 at 23:10 UTC